Change in vdsm[master]: tests: adding gfs2 symlink test
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: adding gfs2 symlink test
......................................................................
Patch Set 1:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8659/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7869/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8790/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
--
To view, visit http://gerrit.ovirt.org/27514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3d6333921505846f345d015907e5f6174af4f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Enrico Tagliavini <enrico.tagliavini(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 1 month
Change in vdsm[master]: caps: Repair collect numa information
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Repair collect numa information
......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1261/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 1 month
Change in vdsm[master]: caps: Repair collect numa information
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: Repair collect numa information
......................................................................
caps: Repair collect numa information
This patch repairs the memory issue about collect numa information
on a non-numa support machine.
If there is only one cell in the result of libvirt's getCapabilities
api, we consider it as non-numa support machine. In this situation,
it will be issue an error when call libvirt's getMemoryStats api.
Instead, we get the memory stats through /proc/meminfo.
Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Bug-Url: https://bugzilla.redhat.com/1069303
Signed-off-by: Bruce Shi <xiao-lei.shi(a)hp.com>
Reviewed-on: http://gerrit.ovirt.org/27090
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/capsTests.py
M vdsm/caps.py
2 files changed, 26 insertions(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Xiaolei Shi: Verified
--
To view, visit http://gerrit.ovirt.org/27090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in vdsm[master]: caps: Repair collect numa information
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: caps: Repair collect numa information
......................................................................
Patch Set 6: -Code-Review
Dan, I see both your points. Removed my score.
--
To view, visit http://gerrit.ovirt.org/27090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 1 month
Change in vdsm[master]: caps: Repair collect numa information
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Repair collect numa information
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/27090/6/vdsm/caps.py
File vdsm/caps.py:
Line 219: memDict = {}
Line 220: memInfo = utils.readMemInfo()
Line 221: memDict['total'] = str(memInfo['MemTotal'] / 1024)
Line 222: memDict['free'] = str(memInfo['MemFree'] / 1024)
Line 223: return memDict
> minor nit:
Francesco, thanks for your review.
Both these issues already exist in accepted code (Cf. _getMemoryStatsByNumaCell), and as such - should be treated in a separate patch.
Since memInfo['MemTotal'] is in KiB, I do not think that there is a real-life rounding issue (I have not seen a memory chip that is not a multiple of MiB for several decades), and rounding down is slightly better than rounding up, anyway.
Line 224:
Line 225:
Line 226: @utils.memoized
Line 227: def _getNumaNodeDistance():
--
To view, visit http://gerrit.ovirt.org/27090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10 years, 1 month
Change in vdsm[master]: caps: Modify memory units of numa node
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Modify memory units of numa node
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1260/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf59a940395cc9d6134503826552fe16053a76f8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 1 month
Change in vdsm[master]: sp: update domain links on state change
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: update domain links on state change
......................................................................
sp: update domain links on state change
In some situations (e.g. after a reconstructMaster command) the
domain links may be missing and it's impossible to recreate them
on connectStoragePool or refreshStoragePool since the storage may
be unreachable. The best we can do is recreate them as soon as
the domains are visible again.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1091030
Change-Id: I7ac20e4b515472b24c35b2cccd2ad3dc98b3574c
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm/storage/sp.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/27334/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 4a07c6a..6b12e44 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -104,6 +104,10 @@
self.domainMonitor = domainMonitor
self._upgradeCallback = partial(StoragePool._upgradePoolDomain,
proxy(self))
+ self._domainStateCallback = partial(
+ StoragePool._domainStateChange, proxy(self))
+ self.domainMonitor.onDomainStateChange.register(
+ self._domainStateCallback)
self._backend = None
def __is_secure__(self):
@@ -137,6 +141,10 @@
def getBackend(self):
return self._backend
+ def _domainStateChange(self, sdUUID, isValid):
+ if isValid and sdUUID in self.getDomains():
+ self._refreshDomainLinks(sdCache.produce(sdUUID))
+
def _upgradePoolDomain(self, sdUUID, isValid):
# This method is called everytime the onDomainStateChange
# event is emitted, this event is emitted even when a domain goes
--
To view, visit http://gerrit.ovirt.org/27334
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ac20e4b515472b24c35b2cccd2ad3dc98b3574c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
10 years, 1 month
Change in vdsm[master]: caps: Modify memory units of numa node
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: Modify memory units of numa node
......................................................................
caps: Modify memory units of numa node
This patch modifies the reported memory units in numa node collection
process. In order to avoid the limitation of xmlrpc, the memory values
are modified to string format in MiB unit.
Change-Id: Ibf59a940395cc9d6134503826552fe16053a76f8
Signed-off-by: Bruce Shi <xiao-lei.shi(a)hp.com>
Reviewed-on: http://gerrit.ovirt.org/27399
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/capsTests.py
M vdsm/caps.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 13 insertions(+), 10 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Xiaolei Shi: Verified
--
To view, visit http://gerrit.ovirt.org/27399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf59a940395cc9d6134503826552fe16053a76f8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in vdsm[master]: caps: Modify memory units of numa node
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Modify memory units of numa node
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf59a940395cc9d6134503826552fe16053a76f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 1 month
Change in vdsm[master]: vm: Modify memory units of numa node
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: vm: Modify memory units of numa node
......................................................................
Patch Set 3:
(1 comment)
One minor style comment, not worth a -1 only for that but please consider.
http://gerrit.ovirt.org/#/c/27403/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 724: for vmCell in guestNumaNodes:
Line 725: nodeMem = int(vmCell['memory']) * 1024
Line 726: numa.appendChildWithArgs('cell',
Line 727: cpus=vmCell['cpus'],
Line 728: memory=str(nodeMem))
please consider (and check if pep8 is OK with it)
numa.appendChildWithArgs(
'cell', cpus=vmCell['cpus'], memory=str(int(vmCell['memory']) * 1024))
Line 729: cpu.appendChild(numa)
Line 730:
Line 731: self.dom.appendChild(cpu)
Line 732:
--
To view, visit http://gerrit.ovirt.org/27403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10 years, 1 month