Change in vdsm[master]: netlink: add route retrieval capability
by asegurap＠redhat.com
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netlink: add route retrieval capability
......................................................................
netlink: add route retrieval capability
Currenlty we use iproute2 external processes and parsing to retrieve
the ip routes and rules that are on the system. This patch implements
the information retrieval using libnl, lowering the resource needs
and increasing the performance.
As an example, to retrieve the the routes that we are interested in
for source routing we would now do:
In [9]: list((route for route in netlink.iter_routes() if route['oif'] == 'dummy_90' and route['scope'] == 'universe' and route['family'] == 'inet')
)
Out[10]:
[{'destination': '240.0.0.0/24',
'destination_length': 24,
'family': 'inet',
'gateway': '240.0.0.1',
'oif': 'dummy_90',
'scope': 'universe',
'source': None,
'source_length': 0,
'table': 252},
{'destination': 'none',
'destination_length': 0,
'family': 'inet',
'gateway': '240.0.0.254',
'oif': 'dummy_90',
'scope': 'universe',
'source': None,
'source_length': 0,
'table': 252}]
Note that it would be easy to extend for the inet6 family and that
the table is wrong due to the bug with 32 bit long tables ids in
el6.
The performance as measured by ipython is:
%timeit list((route for route in netlink.iter_routes() if route['oif'] == 'dummy_90' and route['scope'] == 'universe' and route['family'] == 'inet'))
1000 loops, best of 3: 907 us per loop
While the current solution, before parsing and filtering is:
In [16]: %timeit ipwrapper.routeShowTable('4026531841')
1000 loops, best of 3: 1.81 ms per loop
Note: This is marked as a draft because it lacks libnl3 compatibility
for 'oif' retrieval.
Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M lib/vdsm/netlink.py
1 file changed, 62 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/27317/1
diff --git a/lib/vdsm/netlink.py b/lib/vdsm/netlink.py
index 1638ef7..5b23141 100644
--- a/lib/vdsm/netlink.py
+++ b/lib/vdsm/netlink.py
@@ -55,6 +55,18 @@
addr = _nl_cache_get_next(addr)
+def iter_routes():
+ """Generator that yields an information dictionary for each route in the
+ system."""
+ with _pool.socket() as sock:
+ with _nl_route_cache(sock) as route_cache:
+ with _nl_link_cache(sock) as link_cache: # for index to label
+ route = _nl_cache_get_first(route_cache)
+ while route:
+ yield _route_info(link_cache, route)
+ route = _nl_cache_get_next(route)
+
+
def get_link(name):
"""Returns the information dictionary of the name specified link."""
with _pool.socket() as sock:
@@ -120,6 +132,25 @@
_nl_cache_free(cache)
+def _route_info(link_cache, route):
+ oif_index = _rtnl_route_get_oif(route)
+ if oif_index > 0:
+ oif_label = _link_index_to_name(link_cache, oif_index)
+ else:
+ oif_label = None
+ return {
+ 'destination': _addr_to_str(_rtnl_route_get_dst(route)), # network
+ 'destination_length': _rtnl_route_get_dst_len(route),
+ 'source': _addr_to_str(_rtnl_route_get_src(route)),
+ 'source_length': _rtnl_route_get_src_len(route),
+ 'gateway': _addr_to_str(_rtnl_route_get_gateway(route)), # via
+ 'oif': oif_label,
+ 'table': _rtnl_route_get_table(route),
+ 'table': _rtnl_route_get_table(route),
+ 'family': _address_family_to_str(_rtnl_route_get_family(route)),
+ 'scope': _scope_to_str(_rtnl_route_get_scope(route))}
+
+
def _addr_info(link_cache, addr):
"""Returns a dictionary with the address information."""
index = _rtnl_addr_get_ifindex(addr)
@@ -127,11 +158,11 @@
'label': (_rtnl_addr_get_label(addr) or
_link_index_to_name(link_cache, index)),
'index': index,
- 'family': _addr_family(addr),
+ 'family': _address_family_to_str(_rtnl_addr_get_family(addr)),
'prefixlen': _rtnl_addr_get_prefixlen(addr),
- 'scope': _addr_scope(addr),
+ 'scope': _scope_to_str(_rtnl_addr_get_scope(addr)),
'flags': _rtnl_addr_get_flags(addr),
- 'address': _addr_local(addr)}
+ 'address': addr_to_str(_rtnl_addr_get_local(addr))}
def _link_info(cache, link):
@@ -192,22 +223,24 @@
return _rtnl_link_operstate2str(state, operstate, sizeof(operstate))
-def _addr_scope(addr):
- """Returns the scope name for which the address is defined."""
- scope = (c_char * CHARBUFFSIZE)()
- return _rtnl_scope2str(_rtnl_addr_get_scope(addr), scope, sizeof(scope))
+def _addr_to_str(addr):
+ """Returns the textual representation of a netlink address or None if the
+ address is None"""
+ if addr is not None:
+ address = (c_char * CHARBUFFSIZE)()
+ return _nl_addr2str(addr, address, sizeof(address))
-def _addr_family(addr):
- """Returns the family name of the address."""
+def _address_family_to_str(af_num):
+ """Returns the family name for the adress family numerical identifier"""
family = (c_char * CHARBUFFSIZE)()
- return _nl_af2str(_rtnl_addr_get_family(addr), family, sizeof(family))
+ return _nl_af2str(af_num, family, sizeof(family))
-def _addr_local(addr):
- """Returns the textual representation of the address."""
- address = (c_char * CHARBUFFSIZE)()
- return _nl_addr2str(_rtnl_addr_get_local(addr), address, sizeof(address))
+def _scope_to_str(scope_num):
+ """Returns the scope name for the scope numerical identifier"""
+ scope = (c_char * CHARBUFFSIZE)()
+ return _rtnl_scope2str(scope_num, scope, sizeof(scope))
def _ethtool_uses_libnl3():
@@ -276,6 +309,10 @@
_rtnl_link_vlan_get_id = _int_proto(('rtnl_link_vlan_get_id', LIBNL))
_link_alloc_cache = _void_proto(('rtnl_link_alloc_cache', LIBNL))
_addr_alloc_cache = _void_proto(('rtnl_addr_alloc_cache', LIBNL))
+ _route_alloc_cache = _void_proto(('rtnl_route_alloc_cache', LIBNL))
+ _rtnl_route_get_gateway = _void_proto(('rtnl_route_get_gateway',
+ LIBNL_ROUTE))
+ _rtnl_route_get_oif = _int_proto(('rtnl_route_get_oif', LIBNL_ROUTE))
def _alloc_cache(allocator, sock):
cache = allocator(sock)
@@ -285,6 +322,7 @@
_rtnl_link_alloc_cache = partial(_alloc_cache, _link_alloc_cache)
_rtnl_addr_alloc_cache = partial(_alloc_cache, _addr_alloc_cache)
+ _rtnl_route_alloc_cache = partial(_alloc_cache, _route_alloc_cache)
_nl_connect = CFUNCTYPE(c_int, c_void_p, c_int)(('nl_connect', LIBNL))
_nl_geterror = CFUNCTYPE(c_char_p)(('nl_geterror', LIBNL))
@@ -311,6 +349,15 @@
_rtnl_addr_get_flags = _int_proto(('rtnl_addr_get_flags', LIBNL_ROUTE))
_rtnl_addr_get_local = _void_proto(('rtnl_addr_get_local', LIBNL_ROUTE))
+_rtnl_route_get_dst = _void_proto(('rtnl_route_get_dst', LIBNL_ROUTE))
+_rtnl_route_get_dst_len = _int_proto(('rtnl_route_get_dst_len', LIBNL_ROUTE))
+_rtnl_route_get_src = _void_proto(('rtnl_route_get_src', LIBNL_ROUTE))
+_rtnl_route_get_src_len = _int_proto(('rtnl_route_get_src_len', LIBNL_ROUTE))
+_rtnl_route_get_iif = _char_proto(('rtnl_route_get_iif', LIBNL_ROUTE))
+_rtnl_route_get_table = _int_proto(('rtnl_route_get_table', LIBNL_ROUTE))
+_rtnl_route_get_scope = _int_proto(('rtnl_route_get_scope', LIBNL_ROUTE))
+_rtnl_route_get_family = _int_proto(('rtnl_route_get_family', LIBNL_ROUTE))
+
_nl_addr2str = CFUNCTYPE(c_char_p, c_void_p, c_char_p, c_size_t)((
'nl_addr2str', LIBNL))
_rtnl_link_get_by_name = CFUNCTYPE(c_void_p, c_void_p, c_char_p)((
@@ -326,3 +373,4 @@
_nl_link_cache = partial(_cache_manager, _rtnl_link_alloc_cache)
_nl_addr_cache = partial(_cache_manager, _rtnl_addr_alloc_cache)
+_nl_route_cache = partial(_cache_manager, _rtnl_route_alloc_cache)
--
To view, visit http://gerrit.ovirt.org/27317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
9 years, 10 months
Change in vdsm[master]: netlink: make the scope string stable across libnl1-3
by asegurap＠redhat.com
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netlink: make the scope string stable across libnl1-3
......................................................................
netlink: make the scope string stable across libnl1-3
For globally scoped routes, libnl1 reports 'universe' and libnl3
reports 'global'. This patch makes sure that we only get 'global'.
Change-Id: I700ba3d0997a5c829c460753a300d4529aae2a61
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M lib/vdsm/netlink/__init__.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/29598/1
diff --git a/lib/vdsm/netlink/__init__.py b/lib/vdsm/netlink/__init__.py
index 4f46b98..b9dc943 100644
--- a/lib/vdsm/netlink/__init__.py
+++ b/lib/vdsm/netlink/__init__.py
@@ -103,7 +103,9 @@
def _scope_to_str(scope_num):
"""Returns the textual scope representation of the numerical id"""
scope = (c_char * CHARBUFFSIZE)()
- return _rtnl_scope2str(scope_num, scope, sizeof(scope))
+ scope = _rtnl_scope2str(scope_num, scope, sizeof(scope))
+ # libnl1 reports 'universe' instead of 'global'
+ return scope if scope != 'universe' else 'global'
# C function prototypes
# http://docs.python.org/2/library/ctypes.html#function-prototypes
--
To view, visit http://gerrit.ovirt.org/29598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I700ba3d0997a5c829c460753a300d4529aae2a61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
9 years, 10 months
Change in vdsm[master]: Moving vdsm-logrotate config under vdsm conf dir
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Moving vdsm-logrotate config under vdsm conf dir
......................................................................
Moving vdsm-logrotate config under vdsm conf dir
The outcome of putting the conf under logrotate.d was daily run of
logrotate that specified in logrotate.conf which runs the logrotate.d
scripts. Moving it under vdsm conf dir will allow to use only cron job
for the rotation without system intervention.
Change-Id: Ic5b5376f682b159a3965ce00421ccd0ac0e0f9f7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1113264
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/vdsm-logrotate
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/29624/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index edc3faa..d9d513d 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -4,7 +4,6 @@
./etc/init/supervdsmd.conf
./etc/init/vdsm-tmpfiles.conf
./etc/init/vdsmd.conf
-./etc/logrotate.d/vdsm
./etc/ovirt-config-boot.d/vdsm-config
./etc/pki/vdsm/keys/libvirt_password
./etc/rwtab.d/vdsm
@@ -12,6 +11,7 @@
./etc/sudoers.d/50_vdsm
./etc/sysctl.d/vdsm.conf
./etc/vdsm/logger.conf
+./etc/vdsm/logrotate/vdsm
./etc/vdsm/mom.conf
./etc/vdsm/mom.d/00-defines.policy
./etc/vdsm/mom.d/01-parameters.policy
diff --git a/vdsm.spec.in b/vdsm.spec.in
index dfca5bd..6a8e860 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -952,7 +952,7 @@
%config(noreplace) %{_sysconfdir}/%{vdsm_name}/svdsm.logger.conf
%config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.conf
%config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/*.policy
-%config(noreplace) %{_sysconfdir}/logrotate.d/vdsm
+%config(noreplace) %{_sysconfdir}/%{vdsm_name}/logrotate/vdsm
%config(noreplace) %{_sysconfdir}/rwtab.d/vdsm
%config(noreplace) %{_sysconfdir}/sysctl.d/vdsm.conf
%if 0%{?with_systemd}
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 6016328..96deef2 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -195,9 +195,9 @@
$(RM) $(DESTDIR)$(sysconfdir)/rwtab.d/vdsm
install-data-logrotate:
- $(MKDIR_P) $(DESTDIR)$(sysconfdir)/logrotate.d
+ $(MKDIR_P) $(DESTDIR)$(vdsmconfdir)/logrotate
$(INSTALL_DATA) $(builddir)/vdsm-logrotate.conf \
- $(DESTDIR)$(sysconfdir)/logrotate.d/vdsm
+ $(DESTDIR)$(vdsmconfdir)/logrotate/vdsm
$(MKDIR_P) $(DESTDIR)$(sysconfdir)/cron.hourly
$(INSTALL_SCRIPT) $(srcdir)/vdsm-logrotate \
$(DESTDIR)$(sysconfdir)/cron.hourly/vdsm-logrotate
@@ -206,7 +206,7 @@
$(DESTDIR)$(sysconfdir)/cron.d/vdsm-libvirt-logrotate
uninstall-data-logrotate:
- $(RM) $(DESTDIR)$(sysconfdir)/logrotate.d/vdsm
+ $(RM) $(DESTDIR)$(vdsmconfdir)/logrotate/vdsm
$(RM) $(DESTDIR)$(sysconfdir)/cron.hourly/vdsm-logrotate
$(RM) $(DESTDIR)$(sysconfdir)/cron.d/vdsm-libvirt-logrotate
diff --git a/vdsm/vdsm-logrotate b/vdsm/vdsm-logrotate
index 98767ba..e2027ac 100755
--- a/vdsm/vdsm-logrotate
+++ b/vdsm/vdsm-logrotate
@@ -1,6 +1,6 @@
#!/bin/sh
-/usr/sbin/logrotate /etc/logrotate.d/vdsm
+/usr/sbin/logrotate /etc/vdsm/logrotate/vdsm
EXITVALUE=$?
if [ $EXITVALUE != 0 ]; then
--
To view, visit http://gerrit.ovirt.org/29624
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5b5376f682b159a3965ce00421ccd0ac0e0f9f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 10 months
Change in vdsm[master]: hsm: deleteImage - lock image by imgUUID and sdUUID
by derez＠redhat.com
Daniel Erez has uploaded a new change for review.
Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID
......................................................................
hsm: deleteImage - lock image by imgUUID and sdUUID
hsm -> deleteImage:
An image can reside on two storage domains concurrently
(e.g. during LSM flow: between syncImage and deleteImage phases).
Hence, deleting an image should take an exclusive lock on both
image and storage domain IDs.
Change-Id: I057b1f680276b1eb8a5d910260b7db4c4236fbf5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097648
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/28264/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index e874c23..c4a1b07 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1466,7 +1466,7 @@
pool = self.getPool(spUUID)
dom = sdCache.produce(sdUUID=sdUUID)
- vars.task.getExclusiveLock(STORAGE, imgUUID)
+ vars.task.getExclusiveLock(STORAGE, "%s_%s", imgUUID, sdUUID)
vars.task.getSharedLock(STORAGE, sdUUID)
allVols = dom.getAllVolumes()
volsByImg = sd.getVolsOfImage(allVols, imgUUID)
--
To view, visit http://gerrit.ovirt.org/28264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I057b1f680276b1eb8a5d910260b7db4c4236fbf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
9 years, 10 months
Change in vdsm[master]: Adding requirement for cyrus-sasl-lib and modify the default...
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Adding requirement for cyrus-sasl-lib and modify the default path
Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114993
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M configure.ac
M vdsm.spec.in
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/29625/1
diff --git a/configure.ac b/configure.ac
index 4d03bc7..9dc60bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -232,7 +232,7 @@
AC_PATH_PROG([RM_PATH], [rm], [/bin/rm])
AC_PATH_PROG([RPM_PATH], [rpm], [/bin/rpm])
AC_PATH_PROG([RSYNC_PATH], [rsync], [/usr/bin/rsync])
-AC_PATH_PROG([SASLPASSWD2_PATH], [saslpasswd2], [/sbin/saslpasswd2])
+AC_PATH_PROG([SASLPASSWD2_PATH], [saslpasswd2], [/usr/bin/saslpasswd2])
AC_PATH_PROG([SED_PATH], [sed], [/bin/sed])
AC_PATH_PROG([SERVICE_PATH], [service], [/sbin/service])
AC_PATH_PROG([SETSID_PATH], [setsid], [/usr/bin/setsid])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index dfca5bd..0a74c7c 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -66,6 +66,7 @@
BuildRequires: python-nose
BuildRequires: python-netaddr
BuildRequires: rpm-build
+BuildRequires: cyrus-sasl-lib
# BuildRequires needed by the tests during the build
BuildRequires: dosfstools
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 10 months
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
......................................................................
Patch Set 12:
I'm not sure that we need new verb for the interface name. I'm sure that this should not be a hack in xmlrpc and jsonrpc, but be part of getCaps code.
Since we don't have time to do it properly, lets have this hack now.
--
To view, visit http://gerrit.ovirt.org/28817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 10 months
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
......................................................................
Patch Set 12:
Correction: the getDeviceByIp part must be on the vdsm side. The lastClient can be done in the engine side.
It looks like the device name can be extracted once by using the listen socket, so the thread local can be eliminated. Adding Antoni to review this.
--
To view, visit http://gerrit.ovirt.org/28817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 10 months
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
......................................................................
Patch Set 12:
I think you drop this patch and implement this on the java side of the json rpc.
It should be much simpler on the java side - the code will get the server address from the socket getpeername() and the client address from getsockname().
This can be done in simple way in the getCaps function.
Can you check this before we waste more time on this?
--
To view, visit http://gerrit.ovirt.org/28817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 10 months
Change in vdsm[master]: tests: Add symlink mount test
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: tests: Add symlink mount test
......................................................................
Patch Set 6: Code-Review+1
Look good to me - but I wrote this latest version - someone else should review this.
--
To view, visit http://gerrit.ovirt.org/27514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3d6333921505846f345d015907e5f6174af4f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Enrico Tagliavini <enrico.tagliavini(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Enrico Tagliavini <enrico.tagliavini(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 10 months
