September 2014 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: storage domain detach with force fails

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: storage domain detach with force fails ...................................................................... Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12268/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17058f86448c0019520ea9315da5524c5b3f2b6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: storage domain detach with force fails

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: storage domain detach with force fails ...................................................................... Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11323/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12266/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12112/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17058f86448c0019520ea9315da5524c5b3f2b6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: vm: set status before to invoke suspend

by fromani＠redhat.com

Francesco Romani has uploaded a new change for review. Change subject: vm: set status before to invoke suspend ...................................................................... vm: set status before to invoke suspend Inside the Vm class, the state swapping is not atomic. This is because the reported state is function of two internal fields, lastStatus and guestCpuRunning, which may be updated concurrently and not atomically. One clear example for this is BZ1111938, on which we see a race between pause(), onLibvirtLifeCycle() and getStats(), which makes a Vm incorrectly reported as 'Paused' (instead of 'Saving State'), which confuses Engine. The definitive fix is of course make sure the state changes inside the Vm are atomic ad well handled, but this will require an overhaul of the Vm class internals. This patch provides a short term quick fix by swapping the order of operations, in order to handle this specific case. Change-Id: I3aea96c7122d60e6cb888273678b565c3f3e537f Bug-Url: https://bugzilla.redhat.com/1111938 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/29113/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index d145122..181a18e 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2636,9 +2636,9 @@ try: with self._confLock: self.conf['pauseCode'] = pauseCode + self._lastStatus = afterState self._underlyingPause() self.updateGuestCpuRunning() - self._lastStatus = afterState return {'status': doneCode, 'output': ['']} finally: if not guestCpuLocked: -- To view, visit http://gerrit.ovirt.org/29113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3aea96c7122d60e6cb888273678b565c3f3e537f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>

9 years, 8 months

4
22
0 / 0

Change in vdsm[master]: storage domain detach with force fails

by Allon Mureinik

Allon Mureinik has posted comments on this change. Change subject: storage domain detach with force fails ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32457/1//COMMIT_MSG Commit Message: Line 6: Line 7: storage domain detach with force fails Line 8: Line 9: In jsonrpc schema masterSdUUID and masterVersion are marked as optional. Line 10: We need to provide defautl values for both arguments. s/defautl/default/ Line 11: Line 12: Line 13: Bug-Url: https://bugzilla.redhat.com/1110831 Line 14: Change-Id: I17058f86448c0019520ea9315da5524c5b3f2b6c -- To view, visit http://gerrit.ovirt.org/32457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17058f86448c0019520ea9315da5524c5b3f2b6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: storage domain detach with force fails

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: storage domain detach with force fails ...................................................................... Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11322/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12265/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12111/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17058f86448c0019520ea9315da5524c5b3f2b6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[ovirt-3.5]: setNumberOfCpus marshalling issue

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/146/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5782/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/148/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3941/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1807/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[ovirt-3.5]: setNumberOfCpus marshalling issue

by Dan Kenigsberg

Dan Kenigsberg has submitted this change and it was merged. Change subject: setNumberOfCpus marshalling issue ...................................................................... setNumberOfCpus marshalling issue xmlrpc uses vmID twice to construct VM object and to run setNumberOfCpus. In xmlrpc we provide implementation how we instantiate API object and invoke a verb so we do not care how the parameters are used. Whereas in jsonrpc we use "reflection" so we can't use the same parameter twice. Bug-Url: https://bugzilla.redhat.com/1138181 Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Reviewed-on: http://gerrit.ovirt.org/32454 Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/API.py M vdsm/rpc/BindingXMLRPC.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 8 months

1
0
0 / 0

Change in vdsm[ovirt-3.5]: setNumberOfCpus marshalling issue

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 1: Code-Review+2 Not waiting for Yaniv for this urgent backport. -- To view, visit http://gerrit.ovirt.org/32454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11317/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12106/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches September 2014