September 2014 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11316/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12259/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12105/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Dan Kenigsberg

Dan Kenigsberg has submitted this change and it was merged. Change subject: setNumberOfCpus marshalling issue ...................................................................... setNumberOfCpus marshalling issue xmlrpc uses vmID twice to construct VM object and to run setNumberOfCpus. In xmlrpc we provide implementation how we instantiate API object and invoke a verb so we do not care how the parameters are used. Whereas in jsonrpc we use "reflection" so we can't use the same parameter twice. Bug-Url: https://bugzilla.redhat.com/1138181 Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Reviewed-on: http://gerrit.ovirt.org/32414 Reviewed-by: Roy Golan <rgolan(a)redhat.com> Tested-by: Omer Frenkel <ofrenkel(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/API.py M vdsm/rpc/BindingXMLRPC.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 2: Piotr, I understand the change, but not really your explanation to Michal. Could you improve your commit message? Mention that it's json-rpc only? -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by michal.skrivanek＠redhat.com

Michal Skrivanek has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 2: so..what's the reason for the error? -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by ofrenkel＠redhat.com

Omer Frenkel has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 2: Verified+1 i applied the patch locally, tried hot plug cpu with xml and then with json, both worked -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11300/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12242/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12089/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12243/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by ofrenkel＠redhat.com

Omer Frenkel has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 1: maybe remove from draft and get this in? i think we need it in 3.5 also if json is enabled there by default... -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

Change in vdsm[master]: setNumberOfCpus marshalling issue

by Roy Golan

Roy Golan has posted comments on this change. Change subject: setNumberOfCpus marshalling issue ...................................................................... Patch Set 1: Code-Review+1 correct - I forgot vdsClient uses XMLRPC binding. -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches September 2014