Change in vdsm[master]: packaging: bump libvirt requirements
by fromani＠redhat.com
Francesco Romani has uploaded a new change for review.
Change subject: packaging: bump libvirt requirements
......................................................................
packaging: bump libvirt requirements
With RHEL/Centos 7.1 out of the door, it is
time to bump our libvirt requirements.
Change-Id: Ie63d27705f47690f9788228a2af207e0f439c04a
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M debian/control
M vdsm.spec.in
2 files changed, 14 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/38538/1
diff --git a/debian/control b/debian/control
index 63fc383..a22f029 100644
--- a/debian/control
+++ b/debian/control
@@ -19,7 +19,7 @@
python-dev,
python-cpopen (>= 1.3),
python-dmidecode,
- python-libvirt (>= 1.1.1),
+ python-libvirt (>= 1.2.9),
python-m2crypto,
python-netaddr,
python-nose,
@@ -81,8 +81,8 @@
libnl-utils,
libsanlock-client1 (>= 2.4),
libsanlock-dev (>= 2.4),
- libvirt-bin (>= 1.1.1),
- libvirt0 (>= 1.1.1),
+ libvirt-bin (>= 1.2.9),
+ libvirt0 (>= 1.2.9),
linux-image-generic (>= 3.6),
logrotate,
lvm2 (>= 2.02.95),
@@ -97,7 +97,7 @@
python (>= 2.7.3),
python-cpopen (>= 1.3),
python-dmidecode,
- python-libvirt (>= 1.1.1),
+ python-libvirt (>= 1.2.9),
python-m2crypto,
python-netaddr,
python-parted,
@@ -311,7 +311,7 @@
Package: vdsm-hook-sriov
Architecture: all
-Depends: ${shlibs:Depends}, ${misc:Depends}, python (>=2.7.3), vdsm (>= ${source:Version}), libvirt-bin (>= 1.1.1-1)
+Depends: ${shlibs:Depends}, ${misc:Depends}, python (>=2.7.3), vdsm (>= ${source:Version}), libvirt-bin (>= 1.2.9-1)
Description: sr-iov support for VDSM
sr-iov hook enable to add virtual functions exposed by the device
directly to a virtual machine.
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cc856cd..3d49ba4 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -186,17 +186,20 @@
%endif
%if 0%{?rhel} >= 7 || 0%{?fedora}
-Requires: libvirt-daemon >= 1.1.1
Requires: libvirt-daemon-config-nwfilter
Requires: libvirt-daemon-driver-network
Requires: libvirt-daemon-driver-nwfilter
Requires: libvirt-daemon-driver-qemu
-%else
-%if 0%{?rhel}
-Requires: libvirt >= 0.10.2-29.el6_5.4
-%else
-Requires: libvirt >= 1.1.1
%endif
+# libvirt version
+%if 0%{?rhel}
+%if 0%{?rhel} >= 7
+Requires: libvirt-daemon >= 1.2.8-16
+%else
+Requires: libvirt >= 0.10.2-29.el6_5.4
+%endif # rhel 7
+%else # fedora
+Requires: libvirt >= 1.2.9
%endif
Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client
--
To view, visit https://gerrit.ovirt.org/38538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie63d27705f47690f9788228a2af207e0f439c04a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
8 years, 2 months
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 13:
Build Started (4/7) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/...
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8 years, 2 months
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 13:
Build Started (3/7) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/732/
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8 years, 2 months
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 13:
Build Started (2/7) -> http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_install-rpm-sanity-fc21...
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8 years, 2 months
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 13:
Build Started (1/7) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17416/
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8 years, 2 months
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8 years, 2 months
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by ibarkan＠redhat.com
Ido Barkan has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 12:
(3 comments)
https://gerrit.ovirt.org/#/c/38281/12/lib/vdsm/tool/Makefile.am
File lib/vdsm/tool/Makefile.am:
Line 51: unified_persistence.py \
Line 52: upgrade.py \
Line 53: upgrade_300_networks.py \
Line 54: vdsm-id.py \
Line 55: dump_volume_chains.py \
> This should be sorted - move below dump_bonding_defaults.py
Done
Line 56: $(NULL)
Line 57:
Line 58: CLEANFILES = \
Line 59: config.log \
https://gerrit.ovirt.org/#/c/38281/12/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:
Line 52: pass
Line 53:
Line 54:
Line 55: class ChainError(DumpChainsError):
Line 56: _chainError_message = """Error in volume chain %s: %s
> Why _chainError_message? this is part of ChainError - there is not reason t
Done
Line 57: volumes and parents: %s"""
Line 58:
Line 59: def __init__(self, volumes_children, img_uuid):
Line 60: self.volumes_children = volumes_children
Line 60: self.volumes_children = volumes_children
Line 61: self.img_uuid = img_uuid
Line 62:
Line 63: def __str__(self):
Line 64: volumes = ' '.join(['%s<-%s' % (parent, child) for parent, child in
> This is impossible to read:
Ok, agreed. done.
Line 65: self.volumes_children])
Line 66: return ChainError._chainError_message % (
Line 67: self.img_uuid, self.__class__.__name__, volumes)
Line 68:
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8 years, 2 months
Change in vdsm[ovirt-3.5]: Restart supervdsmd service always and not only on-abort
by ybronhei＠redhat.com
Hello Yeela Kaplan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/39312
to review the following change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Restart supervdsmd service always and not only on-abort
Currently we restart the service only after SIGKILL (on-abort) but the
desire behaviour should be always restarts when the process goes down.
Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39104
Reviewed-by: Yeela Kaplan <ykaplan(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M init/systemd/supervdsmd.service.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/39312/1
diff --git a/init/systemd/supervdsmd.service.in b/init/systemd/supervdsmd.service.in
index 9d3fa7d..7a5e871 100644
--- a/init/systemd/supervdsmd.service.in
+++ b/init/systemd/supervdsmd.service.in
@@ -7,4 +7,4 @@
LimitCORE=infinity
EnvironmentFile=-/etc/sysconfig/supervdsmd
ExecStart=@VDSMDIR@/daemonAdapter "@VDSMDIR@/supervdsmServer" --sockfile "@VDSMRUNDIR(a)/svdsm.sock"
-Restart=on-abort
+Restart=always
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
8 years, 2 months