Change in vdsm[master]: api: use recommended logging
by fromani＠redhat.com
Francesco Romani has uploaded a new change for review.
Change subject: api: use recommended logging
......................................................................
api: use recommended logging
Update the logging in setLogLevel to use
less convoluted and more modern idiom.
Change-Id: I91c3b4aa3344b5093d13fb11e017394cf0bf52b2
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/API.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/38422/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 42c471e..6b8da3a 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1369,8 +1369,7 @@
Doesn't survive a restart
"""
- logging.getLogger('clientIF.setLogLevel').info('Setting loglevel '
- 'to %s' % level)
+ logging.info('Setting loglevel to %s', level)
handlers = logging.getLogger().handlers
[fileHandler] = [h for h in handlers if
isinstance(h, logging.FileHandler)]
--
To view, visit https://gerrit.ovirt.org/38422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91c3b4aa3344b5093d13fb11e017394cf0bf52b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
8 years, 9 months
Change in vdsm[master]: vm: clock: always use rtc timer
by fromani＠redhat.com
Francesco Romani has uploaded a new change for review.
Change subject: vm: clock: always use rtc timer
......................................................................
vm: clock: always use rtc timer
We should always use the <timer name='rtc' tickpolicy='catchup'/> attribute.
It was removed only because of a misunderstandment of the libvirt docs.
Change-Id: If9c3996e95ac0848f9b0a6c7c77b1aeb6da860d7
Bug-Url: https://bugzilla.redhat.com/1215610
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vmxml.py
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/43195/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 038ffcc..96765af 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -338,6 +338,7 @@
clockXML = """
<clock adjustment="-3600" offset="variable">
<timer name="hypervclock"/>
+ <timer name="rtc" tickpolicy="catchup"/>
<timer name="pit" tickpolicy="delay"/>
<timer name="hpet" present="no"/>
</clock>"""
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index 38d2200..7c0be12 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -189,6 +189,7 @@
for hyperv:
<clock offset="variable" adjustment="-3600">
<timer name="hypervclock">
+ <timer name="rtc" tickpolicy="catchup">
</clock>
"""
@@ -196,8 +197,7 @@
adjustment=str(self.conf.get('timeOffset', 0)))
if utils.tobool(self.conf.get('hypervEnable', 'false')):
m.appendChildWithArgs('timer', name='hypervclock')
- else:
- m.appendChildWithArgs('timer', name='rtc', tickpolicy='catchup')
+ m.appendChildWithArgs('timer', name='rtc', tickpolicy='catchup')
m.appendChildWithArgs('timer', name='pit', tickpolicy='delay')
if self.arch == caps.Architecture.X86_64:
--
To view, visit https://gerrit.ovirt.org/43195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9c3996e95ac0848f9b0a6c7c77b1aeb6da860d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
8 years, 9 months
Change in vdsm[master]: vm: event: emit event on setDownStatus
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: vm: event: emit event on setDownStatus
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/43270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a99d074461bcc2b61d15dd46f7d020abbe48afe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 9 months
Change in vdsm[master]: vm: emit event when domDependentInit is done
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: vm: emit event when domDependentInit is done
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/43269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie379911a374a9ba3e82658592c295f7a9a0ac8a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 9 months
Change in vdsm[master]: virt: events: extract function to make event info
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: virt: events: extract function to make event info
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/43268
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If60e8422d06fb1ff45a846858856ad68d52fd6ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 9 months
Change in vdsm[master]: gluster.hostname: simplify by using a constant for the 'host...
by osvoboda＠redhat.com
Ondřej Svoboda has uploaded a new change for review.
Change subject: gluster.hostname: simplify by using a constant for the 'hostname' executable
......................................................................
gluster.hostname: simplify by using a constant for the 'hostname' executable
Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com>
---
M lib/vdsm/constants.py.in
M vdsm/gluster/Makefile.am
R vdsm/gluster/hostname.py
3 files changed, 5 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/37621/1
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 89bdebd..fa65b0c 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -114,6 +114,8 @@
EXT_GREP = '@GREP_PATH@'
+EXT_HOSTNAME = '@HOSTNAME_PATH@'
+
EXT_IFDOWN = '@IFDOWN_PATH@'
EXT_IFUP = '@IFUP_PATH@'
EXT_IONICE = '@IONICE_PATH@'
diff --git a/vdsm/gluster/Makefile.am b/vdsm/gluster/Makefile.am
index 96b8054..da32685 100644
--- a/vdsm/gluster/Makefile.am
+++ b/vdsm/gluster/Makefile.am
@@ -22,10 +22,6 @@
vdsmglusterdir = $(vdsmdir)/gluster
-nodist_vdsmgluster_PYTHON = \
- hostname.py
- $(NULL)
-
dist_vdsmgluster_PYTHON = \
__init__.py \
api.py \
@@ -33,19 +29,9 @@
cli.py \
exception.py \
gfapi.py \
+ hostname.py \
hooks.py \
services.py \
storagedev.py \
tasks.py \
$(NULL)
-
-EXTRA_DIST = \
- hostname.py.in
- $(NULL)
-
-CLEANFILES = \
- hostname.py
- $(NULL)
-
-all-local: \
- $(nodist_vdsmgluster_PYTHON)
diff --git a/vdsm/gluster/hostname.py.in b/vdsm/gluster/hostname.py
similarity index 91%
rename from vdsm/gluster/hostname.py.in
rename to vdsm/gluster/hostname.py
index c817b0a..6b30ac3 100644
--- a/vdsm/gluster/hostname.py.in
+++ b/vdsm/gluster/hostname.py
@@ -18,6 +18,7 @@
# Refer to the README and COPYING files for full details of the license
#
+from vdsm import constants
from vdsm import utils
@@ -31,7 +32,7 @@
def getHostNameFqdn():
- rc, out, err = utils.execCmd(['@HOSTNAME_PATH@', '--fqdn'])
+ rc, out, err = utils.execCmd([constants.EXT_HOSTNAME, '--fqdn'])
if rc:
raise HostNameException(rc)
else:
--
To view, visit http://gerrit.ovirt.org/37621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
8 years, 9 months
Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() verbs
by Vinzenz Feenstra
Vinzenz Feenstra has posted comments on this change.
Change subject: snapshot: Add VM.freeze() and VM.thaw() verbs
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 9 months
Change in vdsm[master]: vdsm-reg: remove the sub-project
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
......................................................................
Patch Set 1: Verified+1
I could generate vdsm without vdsm-reg package.
RIP vdsm-reg.
--
To view, visit https://gerrit.ovirt.org/43254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d19ddb0e65657515e2dc0eb9eeae320d8d6bf71
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 9 months
Change in vdsm[master]: vdsm-reg: remove the sub-project
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
......................................................................
Patch Set 1:
* Update tracker::#1231379::OK
* Check Bug-Url::OK
* Check Public Bug::#1231379::OK, public bug
* Check Product::#1231379::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/43254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d19ddb0e65657515e2dc0eb9eeae320d8d6bf71
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 9 months
Change in vdsm[master]: tests: restore default timeout value
by Piotr Kliczewski
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: restore default timeout value
......................................................................
tests: restore default timeout value
CI machines are overloaded with work so we need to give the test a bit
more time before we assume that the response not arrived.
Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M tests/jsonRpcTests.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/42918/1
diff --git a/tests/jsonRpcTests.py b/tests/jsonRpcTests.py
index 3606bba..7bd6dbc 100644
--- a/tests/jsonRpcTests.py
+++ b/tests/jsonRpcTests.py
@@ -41,7 +41,7 @@
JsonRpcRequest
-CALL_TIMEOUT = 3
+CALL_TIMEOUT = 15
CALL_ID = '2c8134fd-7dd4-4cfc-b7f8-6b7549399cb6'
--
To view, visit https://gerrit.ovirt.org/42918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
8 years, 9 months
