vdsm-patches October 2016

vdsm-patches@lists.fedorahosted.org

33 participants
468 discussions

Change in vdsm[master]: tests: Add tests for poll and wait failures
by automation＠ovirt.org 13 Oct '16

13 Oct '16

gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for poll and wait failures ...................................................................... Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8674c9c3c2118041c74213cd8ce0d383086d6cbf Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: network: supervdsm: configure container networks
by automation＠ovirt.org 12 Oct '16

12 Oct '16

gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks ...................................................................... Patch Set 45: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsm: virt: add optional container support
by automation＠ovirt.org 12 Oct '16

12 Oct '16

gerrit-hooks has posted comments on this change. Change subject: vdsm: virt: add optional container support ...................................................................... Patch Set 52: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 52 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: supervdsm: expose systemd utilities
by automation＠ovirt.org 12 Oct '16

12 Oct '16

gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities ...................................................................... Patch Set 32: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: network: supervdsm: configure container networks
by Martin Polednik 12 Oct '16

12 Oct '16

Martin Polednik has posted comments on this change. Change subject: network: supervdsm: configure container networks ...................................................................... Patch Set 44: The code is somewhat fine considering the TODOs, but question remains: if I install vdsm-containers AFTER already using VDSM, do I explicitly have to setup_networks again? How is user informed? -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsm: virt: add optional container support
by Martin Polednik 12 Oct '16

12 Oct '16

Martin Polednik has posted comments on this change. Change subject: vdsm: virt: add optional container support ...................................................................... Patch Set 51: Code-Review-1 (9 comments) https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containersconnection.py File lib/vdsm/containersconnection.py: PS51, Line 33: _runtimes = frozenset() I have inner hate for how this is further "calculated" (also considering the followup patch) - do we *have to* use the frozenset? I can't see the benefit of overwriting frozenset 3 times over |='ing it. https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py File lib/vdsm/containerslib.py: PS51, Line 99: def _is_cmd(argv, reqv): Why this isn't attribute of SuperVdsmCommand class? It's slight implementation leak imho. PS51, Line 113: def _call(ret): Same as above, I believe it should be __call__ on top of that (internally calling self._execute). PS51, Line 153: container connection PS51, Line 161: ev s/ev/event PS51, Line 177: For clearing connections during the tests. Only? Runtime code shouldn't be polluted by test helpers. https://gerrit.ovirt.org/#/c/53820/51/vdsm/virt/recovery.py File vdsm/virt/recovery.py: PS51, Line 167: all_vms s/vms/domains ? PS51, Line 177: def _all_vms_from_runtime(cif): s/vms/domains ? Also, what does runtime mean in this context? We're not in any runtime in recovery flow afaik. https://gerrit.ovirt.org/#/c/53820/51/vdsm/virt/vm.py File vdsm/virt/vm.py: PS51, Line 1657: if is_kvm(self.conf): My vote for split or helper function remains. -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client
by akrejcir＠redhat.com 12 Oct '16

12 Oct '16

Hello Piotr Kliczewski, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65378 to review the following change. Change subject: Add all MOM calls to jsonrpc client ...................................................................... Add all MOM calls to jsonrpc client Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/60492 Reviewed-by: Francesco Romani <fromani(a)redhat.com> Tested-by: Andrej Krejcir <akrejcir(a)redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Reviewed-on: https://gerrit.ovirt.org/63479 --- M lib/vdsm/jsonrpcvdscli.py M lib/vdsm/rpc/Bridge.py 2 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/65378/1 diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py index caffb9a..1854869 100644 --- a/lib/vdsm/jsonrpcvdscli.py +++ b/lib/vdsm/jsonrpcvdscli.py @@ -60,6 +60,8 @@ 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools', 'getDeviceList': 'Host.getDeviceList', 'getImagesList': 'StorageDomain.getImages', + 'getIoTunePolicy': 'VM.getIoTunePolicy', + 'getIoTune': 'VM.getIoTune', 'getSpmStatus': 'StoragePool.getSpmStatus', 'getStorageDomainInfo': 'StorageDomain.getInfo', 'getStorageDomainsList': 'Host.getStorageDomains', @@ -93,10 +95,12 @@ 'setBalloonTarget': 'VM.setBalloonTarget', 'setCpuTunePeriod': 'VM.setCpuTunePeriod', 'setCpuTuneQuota': 'VM.setCpuTuneQuota', + 'setKsmTune': 'Host.setKsmTune', 'setMOMPolicy': 'Host.setMOMPolicy', 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig', 'setupNetworks': 'Host.setupNetworks', 'setVmTicket': 'VM.setTicket', + 'setIoTune': 'VM.setIoTune', 'setVolumeDescription': 'Volume.setDescription', 'shutdown': 'VM.shutdown', 'spmStart': 'StoragePool.spmStart', diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py index 273bd2e..192de42 100644 --- a/lib/vdsm/rpc/Bridge.py +++ b/lib/vdsm/rpc/Bridge.py @@ -349,7 +349,7 @@ 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'}, 'Host_getAllVmStats': {'ret': 'statsList'}, 'Host_setupNetworks': {'ret': 'status'}, - 'Host_setKsmTune': {'ret': 'taskStatus'}, + 'Host_setKsmTune': {'ret': 'status'}, 'Image_cloneStructure': {'ret': 'uuid'}, 'Image_delete': {'ret': 'uuid'}, 'Image_deleteVolumes': {'ret': 'uuid'}, @@ -402,11 +402,12 @@ 'VM_migrationCreate': {'ret': VM_migrationCreate_Ret}, 'VM_getMigrationStatus': {'ret': 'migrationStats'}, 'VM_pause': {'ret': VM_running_state_change_Ret}, - 'VM_setCpuTunePeriod': {'ret': 'taskStatus'}, - 'VM_setCpuTuneQuota': {'ret': 'taskStatus'}, + 'VM_setCpuTunePeriod': {'ret': 'status'}, + 'VM_setCpuTuneQuota': {'ret': 'status'}, 'VM_hotplugMemory': {'ret': 'vmList'}, 'VM_setNumberOfCpus': {'ret': 'vmList'}, - 'VM_setIoTune': {'ret': 'taskStatus'}, + 'VM_setIoTune': {'ret': 'status'}, + 'VM_setBalloonTarget': {'ret': 'status'}, 'VM_updateDevice': {'ret': 'vmList'}, 'Volume_copy': {'ret': 'uuid'}, 'Volume_create': {'ret': 'uuid'}, -- To view, visit https://gerrit.ovirt.org/65378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

3 7

Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls
by akrejcir＠redhat.com 12 Oct '16

12 Oct '16

Hello Piotr Kliczewski, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65377 to review the following change. Change subject: Fix return value names for VM.ioTune calls ...................................................................... Fix return value names for VM.ioTune calls Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/60513 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/63478 Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M tests/vmTests.py M vdsm/virt/vm.py 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/65377/1 diff --git a/tests/vmTests.py b/tests/vmTests.py index 6d38f46..7965317 100644 --- a/tests/vmTests.py +++ b/tests/vmTests.py @@ -864,7 +864,7 @@ u'totalBytes': 9999 }} ] - self.assertEqual(tunables['ioTunePolicy'], expected) + self.assertEqual(tunables['ioTunePolicyList'], expected) def testSetIoTune(self): diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index a896f58..bfe61f0 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2738,12 +2738,12 @@ qos = self._getVmPolicy() ioTuneList = qos.getElementsByTagName("ioTune") if not ioTuneList or not ioTuneList[0].hasChildNodes(): - return response.success(ioTunePolicy=[]) + return response.success(ioTunePolicyList=[]) for device in ioTuneList[0].getElementsByTagName("device"): tunables.append(io_tune_dom_to_values(device)) - return response.success(ioTunePolicy=tunables) + return response.success(ioTunePolicyList=tunables) def getIoTune(self): resultList = [] @@ -2776,7 +2776,7 @@ else: return response.error('updateIoTuneErr', e.message) - return response.success(ioTune=resultList) + return response.success(ioTuneList=resultList) def setIoTune(self, tunables): for io_tune_change in tunables: -- To view, visit https://gerrit.ovirt.org/65377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

3 7

Change in vdsm[master]: supervdsm: expose systemd utilities
by Martin Polednik 12 Oct '16

12 Oct '16

Martin Polednik has posted comments on this change. Change subject: supervdsm: expose systemd utilities ...................................................................... Patch Set 31: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client
by Martin Sivak 12 Oct '16

12 Oct '16

Hello Piotr Kliczewski, Francesco Romani, Andrej Krejcir, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/63479 to review the following change. Change subject: Add all MOM calls to jsonrpc client ...................................................................... Add all MOM calls to jsonrpc client Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/60492 Reviewed-by: Francesco Romani <fromani(a)redhat.com> Tested-by: Andrej Krejcir <akrejcir(a)redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M lib/vdsm/jsonrpcvdscli.py M lib/vdsm/rpc/Bridge.py 2 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/63479/1 diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py index caffb9a..1854869 100644 --- a/lib/vdsm/jsonrpcvdscli.py +++ b/lib/vdsm/jsonrpcvdscli.py @@ -60,6 +60,8 @@ 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools', 'getDeviceList': 'Host.getDeviceList', 'getImagesList': 'StorageDomain.getImages', + 'getIoTunePolicy': 'VM.getIoTunePolicy', + 'getIoTune': 'VM.getIoTune', 'getSpmStatus': 'StoragePool.getSpmStatus', 'getStorageDomainInfo': 'StorageDomain.getInfo', 'getStorageDomainsList': 'Host.getStorageDomains', @@ -93,10 +95,12 @@ 'setBalloonTarget': 'VM.setBalloonTarget', 'setCpuTunePeriod': 'VM.setCpuTunePeriod', 'setCpuTuneQuota': 'VM.setCpuTuneQuota', + 'setKsmTune': 'Host.setKsmTune', 'setMOMPolicy': 'Host.setMOMPolicy', 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig', 'setupNetworks': 'Host.setupNetworks', 'setVmTicket': 'VM.setTicket', + 'setIoTune': 'VM.setIoTune', 'setVolumeDescription': 'Volume.setDescription', 'shutdown': 'VM.shutdown', 'spmStart': 'StoragePool.spmStart', diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py index 273bd2e..192de42 100644 --- a/lib/vdsm/rpc/Bridge.py +++ b/lib/vdsm/rpc/Bridge.py @@ -349,7 +349,7 @@ 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'}, 'Host_getAllVmStats': {'ret': 'statsList'}, 'Host_setupNetworks': {'ret': 'status'}, - 'Host_setKsmTune': {'ret': 'taskStatus'}, + 'Host_setKsmTune': {'ret': 'status'}, 'Image_cloneStructure': {'ret': 'uuid'}, 'Image_delete': {'ret': 'uuid'}, 'Image_deleteVolumes': {'ret': 'uuid'}, @@ -402,11 +402,12 @@ 'VM_migrationCreate': {'ret': VM_migrationCreate_Ret}, 'VM_getMigrationStatus': {'ret': 'migrationStats'}, 'VM_pause': {'ret': VM_running_state_change_Ret}, - 'VM_setCpuTunePeriod': {'ret': 'taskStatus'}, - 'VM_setCpuTuneQuota': {'ret': 'taskStatus'}, + 'VM_setCpuTunePeriod': {'ret': 'status'}, + 'VM_setCpuTuneQuota': {'ret': 'status'}, 'VM_hotplugMemory': {'ret': 'vmList'}, 'VM_setNumberOfCpus': {'ret': 'vmList'}, - 'VM_setIoTune': {'ret': 'taskStatus'}, + 'VM_setIoTune': {'ret': 'status'}, + 'VM_setBalloonTarget': {'ret': 'status'}, 'VM_updateDevice': {'ret': 'vmList'}, 'Volume_copy': {'ret': 'uuid'}, 'Volume_create': {'ret': 'uuid'}, -- To view, visit https://gerrit.ovirt.org/63479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

5 9

← Newer
1
...
26
27
28
29
30
31
32
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2016