Change in vdsm[master]: properties: Python 3 compliant base64 usage
by Nir Soffer
Nir Soffer has submitted this change and it was merged.
Change subject: properties: Python 3 compliant base64 usage
......................................................................
properties: Python 3 compliant base64 usage
base64.b64encode and base64.b64decode receive and return byte
arrays respectively -- pass a bytes literal in both py2 and py3
as input for b64encode and modify test_decode to test for equality
to a bytes literal in both py2 and py3.
Change-Id: I6f63b33a44e465806e00ed3de0b1e55e8a01005f
Signed-off-by: Leon Goldberg <leon.otium(a)gmail.com>
Reviewed-on: https://gerrit.ovirt.org/63714
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Tested-by: Nir Soffer <nsoffer(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M tests/properties_test.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f63b33a44e465806e00ed3de0b1e55e8a01005f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in vdsm[master]: properties: Python 3 compatible string type check
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/63709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fb0b3f5fd5ae12710684aade233c80dbcc5f2a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Python 3 compatible string type check
by Nir Soffer
Nir Soffer has submitted this change and it was merged.
Change subject: properties: Python 3 compatible string type check
......................................................................
properties: Python 3 compatible string type check
basestring is removed in py3; now using six.string_types instead.
Change-Id: I63fb0b3f5fd5ae12710684aade233c80dbcc5f2a
Signed-off-by: Leon Goldberg <leon.otium(a)gmail.com>
Reviewed-on: https://gerrit.ovirt.org/63709
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Tested-by: Nir Soffer <nsoffer(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/properties.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63fb0b3f5fd5ae12710684aade233c80dbcc5f2a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in vdsm[master]: properties: Use python 3 compatible metaclass
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/63710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac99f68a32c9218eb93031fb4c6e2808cb88fc3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Use python 3 compatible metaclass
by Nir Soffer
Nir Soffer has submitted this change and it was merged.
Change subject: properties: Use python 3 compatible metaclass
......................................................................
properties: Use python 3 compatible metaclass
Setting metaclass differs in py2/3; now using six's add_metaclass
decorator to comply with both py2 and 3.
Change-Id: Icac99f68a32c9218eb93031fb4c6e2808cb88fc3
Signed-off-by: Leon Goldberg <leon.otium(a)gmail.com>
Reviewed-on: https://gerrit.ovirt.org/63710
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Tested-by: Nir Soffer <nsoffer(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/properties.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icac99f68a32c9218eb93031fb4c6e2808cb88fc3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in vdsm[master]: properties: py3: properties.py and properties_test.py compli...
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
......................................................................
Patch Set 3:
Your new patches replace this patch, you can abandon it now.
--
To view, visit https://gerrit.ovirt.org/63230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3f49dd718d786c4a98b06c7b8757ce5a9eb6d2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Python 3 compliant base64 usage
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compliant base64 usage
......................................................................
Patch Set 2: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/63714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f63b33a44e465806e00ed3de0b1e55e8a01005f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Python 3 compatible string type check
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
......................................................................
Patch Set 3: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/63709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fb0b3f5fd5ae12710684aade233c80dbcc5f2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Use python 3 compatible metaclass
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
......................................................................
Patch Set 4: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/63710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac99f68a32c9218eb93031fb4c6e2808cb88fc3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Python 3 compliant base64 usage
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compliant base64 usage
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f63b33a44e465806e00ed3de0b1e55e8a01005f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
