Change in vdsm[master]: properties: Python 3 compliant base64 usage
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: properties: Python 3 compliant base64 usage
......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/63714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f63b33a44e465806e00ed3de0b1e55e8a01005f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Python 3 compatible string type check
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
......................................................................
Patch Set 3: Code-Review+2
Rebased on previous properties python 3 patch, it is easier to review and test when we group related patches.
--
To view, visit https://gerrit.ovirt.org/63709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fb0b3f5fd5ae12710684aade233c80dbcc5f2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Python 3 compatible string type check
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/63709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fb0b3f5fd5ae12710684aade233c80dbcc5f2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Use python 3 compatible metaclass
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/63710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac99f68a32c9218eb93031fb4c6e2808cb88fc3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Use python 3 compatible metaclass
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
......................................................................
Patch Set 3: Code-Review+2
Removed extra line at the end of the file and, move six import to 3rd party import group, and cleanup commit message.
--
To view, visit https://gerrit.ovirt.org/63710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac99f68a32c9218eb93031fb4c6e2808cb88fc3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: properties: Use python 3 compatible metaclass
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/63710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac99f68a32c9218eb93031fb4c6e2808cb88fc3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: api: Speed up schema loading
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: api: Speed up schema loading
......................................................................
api: Speed up schema loading
Use yaml.CLoader for 13x speedup in vdsm schema loading.
Here is a comparison with other formats:
$ python bench.py
yaml: 1.053720 seconds per load
cyaml: 0.086472 seconds per load
json: 0.049521 seconds per load
pickle: 0.001516 seconds per load
$ python3 bench.py
yaml: 1.340607 seconds per load
cyaml: 0.100010 seconds per load
json: 0.026627 seconds per load
pickle: 0.002153 seconds per load
$ grep 'model name' /proc/cpuinfo | head -n1
model name : Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Clearly the best format is pickle, 700X times faster on python 2 and
638X times faster on python 3. However loading the schema in 100
milliseconds seems to be good enough for now.
The benchmark script:
https://bugzilla.redhat.com/attachment.cgi?id=1208141
Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Bug-Url: https://bugzilla.redhat.com/1381899
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/api/vdsmapi.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/65230/1
diff --git a/lib/api/vdsmapi.py b/lib/api/vdsmapi.py
index 4f79efb..ced56dd 100755
--- a/lib/api/vdsmapi.py
+++ b/lib/api/vdsmapi.py
@@ -125,7 +125,7 @@
try:
for path in paths:
with open(path) as f:
- loaded_schema = yaml.load(f)
+ loaded_schema = yaml.load(f, Loader=yaml.CLoader)
types = loaded_schema.pop('types')
self._types.update(types)
--
To view, visit https://gerrit.ovirt.org/65230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: vm: Add qcow2_compat on create
by Maor Lipchuk
Maor Lipchuk has uploaded a new change for review.
Change subject: vm: Add qcow2_compat on create
......................................................................
vm: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/64377/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 1d9a3d5..90bf998 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2701,7 +2701,8 @@
try:
qemuimg.create(transientPath, format=qemuimg.FORMAT.QCOW2,
backing=diskParams['path'],
- backingFormat=driveFormat)
+ backingFormat=driveFormat,
+ qcow2_compat=self._dom)
os.fchmod(transientHandle, 0o660)
except Exception:
os.unlink(transientPath) # Closing after deletion is correct
--
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: sp: Streamline image namespace locking
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: sp: Streamline image namespace locking
......................................................................
sp: Streamline image namespace locking
Replace imageResourcesNamespace with img_ns, streamlining acquiring of
image namespace locks.
The namespace is used in the context of single function, mostly very
small functions, so we don't need a long and descriptive name. Shorter
variables names are better in such context.
Change-Id: I21fe6224059f1624facd95c3a6e1ba671c7deda6
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/sp.py
1 file changed, 15 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/65040/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index b56792a..eb0ca1d 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1342,9 +1342,8 @@
sdCache.produce(sdUUID).extendVolume(volumeUUID, size, isShuttingDown)
def extendVolumeSize(self, sdUUID, imgUUID, volUUID, newSize):
- imageResourcesNamespace = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
- with rm.acquireResource(imageResourcesNamespace, imgUUID,
- rm.EXCLUSIVE):
+ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
+ with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE):
return sdCache.produce(sdUUID) \
.produceVolume(imgUUID, volUUID).extendSize(int(newSize))
@@ -1793,9 +1792,8 @@
:returns: A dict with a list of volume UUIDs in the corrected chain
:rtype: dict
"""
- imageResourcesNamespace = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
- with rm.acquireResource(imageResourcesNamespace, imgUUID,
- rm.EXCLUSIVE):
+ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
+ with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE):
img = image.Image(self.poolPath)
chain = img.reconcileVolumeChain(sdUUID, imgUUID, leafVolUUID)
return dict(volumes=chain)
@@ -1819,10 +1817,9 @@
:param postZero: ?
:type postZero: bool?
"""
- imageResourcesNamespace = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
+ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
- with rm.acquireResource(imageResourcesNamespace, imgUUID,
- rm.EXCLUSIVE):
+ with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE):
image.Image(self.poolPath).merge(
sdUUID, vmUUID, imgUUID, ancestor, successor, postZero)
@@ -1869,7 +1866,7 @@
:returns: a dict with the UUID of the new volume.
:rtype: dict
"""
- imageResourcesNamespace = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
+ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
if imgUUID != srcImgUUID and srcImgUUID != sc.BLANK_UUID:
srcDom = sdCache.produce(sdUUID)
@@ -1878,9 +1875,7 @@
if not srcVol.isShared():
if srcVol.getParent() == sc.BLANK_UUID:
- with rm.acquireResource(imageResourcesNamespace,
- srcImgUUID,
- rm.EXCLUSIVE):
+ with rm.acquireResource(img_ns, srcImgUUID, rm.EXCLUSIVE):
self.log.debug("volume %s is not shared. "
"Setting it as shared", srcVolUUID)
@@ -1888,8 +1883,7 @@
else:
raise se.VolumeNonShareable(srcVol)
- with rm.acquireResource(imageResourcesNamespace, imgUUID,
- rm.EXCLUSIVE):
+ with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE):
newVolUUID = sdCache.produce(sdUUID).createVolume(
imgUUID=imgUUID, size=size, volFormat=volFormat,
preallocate=preallocate, diskType=diskType, volUUID=volUUID,
@@ -1915,10 +1909,9 @@
have.
:type imgUUID: UUID
"""
- imageResourcesNamespace = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
+ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
- with rm.acquireResource(imageResourcesNamespace, imgUUID,
- rm.EXCLUSIVE):
+ with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE):
dom = sdCache.produce(sdUUID)
for volUUID in volumes:
dom.produceVolume(imgUUID, volUUID).delete(
@@ -1969,18 +1962,16 @@
def setVolumeDescription(self, sdUUID, imgUUID, volUUID, description):
self.validatePoolSD(sdUUID)
- imageResourcesNamespace = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
- with rm.acquireResource(imageResourcesNamespace, imgUUID,
- rm.EXCLUSIVE):
+ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
+ with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE):
sdCache.produce(sdUUID).produceVolume(
imgUUID=imgUUID,
volUUID=volUUID).setDescription(descr=description)
def setVolumeLegality(self, sdUUID, imgUUID, volUUID, legality):
self.validatePoolSD(sdUUID)
- imageResourcesNamespace = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
- with rm.acquireResource(imageResourcesNamespace, imgUUID,
- rm.EXCLUSIVE):
+ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID)
+ with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE):
sdCache.produce(sdUUID).produceVolume(
imgUUID=imgUUID,
volUUID=volUUID).setLegality(legality=legality)
--
To view, visit https://gerrit.ovirt.org/65040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21fe6224059f1624facd95c3a6e1ba671c7deda6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: tests: Mark integration tests
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: tests: Mark integration tests
......................................................................
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/55730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months