Change in vdsm[master]: tests: Fix test to not wait forever on failure
by alitke＠redhat.com
Adam Litke has uploaded a new change for review.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
tests: Fix test to not wait forever on failure
Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Signed-off-by: Adam Litke <alitke(a)redhat.com>
---
M tests/storage_sdm_copy_data_test.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/65149/1
diff --git a/tests/storage_sdm_copy_data_test.py b/tests/storage_sdm_copy_data_test.py
index 948d170..6b116d5 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -275,7 +275,8 @@
job_id = make_uuid()
job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest)
t = start_thread(job.run)
- fake_convert.ready_event.wait()
+ if not fake_convert.ready_event.wait(1):
+ raise RuntimeError("Timeout waiting for thread")
job.abort()
t.join(1)
if t.isAlive():
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
......................................................................
Patch Set 19:
* update_tracker: OK
* Set MODIFIED::bug 1356161::::#1356161::IGNORE, skipping for branch 'master'
--
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: prefer numa nodes close to device MMIO
......................................................................
hostdev: prefer numa nodes close to device MMIO
Therefore reducing the NUMA distance if VM's memory was away from VM
host device's MMIO region.
Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356161
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/60640
Reviewed-by: Milan Zamazal <mzamazal(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/config.py.in
M tests/hostdevTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
4 files changed, 52 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in vdsm[master]: drop dead constant
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: drop dead constant
......................................................................
drop dead constant
It has not been used in code since commit 87f0129.
Change-Id: I1c3651d296ee757752bee659fa08835bd385e91a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M configure.ac
M lib/vdsm/constants.py.in
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/65097/1
diff --git a/configure.ac b/configure.ac
index 2b546d2..e9c672c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -330,7 +330,6 @@
AC_PATH_PROG([CHCON_PATH], [chcon], [/bin/chcon])
AC_PATH_PROG([CHMOD_PATH], [chmod], [/bin/chmod])
AC_PATH_PROG([CHOWN_PATH], [chown], [/bin/chown])
-AC_PATH_PROG([CP_PATH], [cp], [/bin/cp])
AC_PATH_PROG([DD_PATH], [dd], [/bin/dd])
AC_PATH_PROG([DMIDECODE_PATH], [dmidecode], [/usr/sbin/dmidecode])
AC_PATH_PROG([DMSETUP_PATH], [dmsetup], [/sbin/dmsetup])
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 86a6897..5f33f24 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -102,7 +102,6 @@
EXT_BRCTL = '@BRCTL_PATH@'
EXT_CHOWN = '@CHOWN_PATH@'
-EXT_CP = '@CP_PATH@'
EXT_DD = '@DD_PATH@'
EXT_DMIDECODE = '@DMIDECODE_PATH@'
--
To view, visit https://gerrit.ovirt.org/65097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c3651d296ee757752bee659fa08835bd385e91a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
......................................................................
Patch Set 18:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: vmxml: move condition from appendNumaTune to buildDomainXML
by Martin Polednik
Martin Polednik has uploaded a new change for review.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
......................................................................
vmxml: move condition from appendNumaTune to buildDomainXML
Having the condition that explicit numa tuning was requested in
buildDomainXML(vm.py) instead of appendNumaTune(vmxml.py) makes the
flow slightly more obvious and allows for work done by further patches
in the series.
Change-Id: I7141cfe8d5ed086dde884234990a3c00ddca2092
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/61929/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 88d3d97..a78c1b1 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1518,7 +1518,8 @@
domxml.appendCpu()
- domxml.appendNumaTune()
+ if 'numaTune' in self.conf:
+ domxml.appendNumaTune()
domxml._appendAgentDevice(self._guestSocketFile.decode('utf-8'),
vmchannels.DEVICE_NAME)
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index d187992..4052228 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -501,14 +501,13 @@
</numatune>
"""
- if 'numaTune' in self.conf:
- numaTune = self.conf.get('numaTune')
- if 'nodeset' in numaTune.keys():
- mode = numaTune.get('mode', 'strict')
- numatune = Element('numatune')
- numatune.appendChildWithArgs('memory', mode=mode,
- nodeset=numaTune['nodeset'])
- self.dom.appendChild(numatune)
+ numaTune = self.conf.get('numaTune')
+ if 'nodeset' in numaTune.keys():
+ mode = numaTune.get('mode', 'strict')
+ numatune = Element('numatune')
+ numatune.appendChildWithArgs('memory', mode=mode,
+ nodeset=numaTune['nodeset'])
+ self.dom.appendChild(numatune)
def _appendAgentDevice(self, path, name):
"""
--
To view, visit https://gerrit.ovirt.org/61929
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7141cfe8d5ed086dde884234990a3c00ddca2092
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: hostdev: properly set is_hostdevice
by Martin Polednik
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: properly set is_hostdevice
......................................................................
hostdev: properly set is_hostdevice
Since we added is_hostdevice attribute to all devices, and the
attribute defaults to false, we have to explicitly set it to true for
host devices.
Change-Id: Ie4b70f698fb1e6d8a8adec650d5a91d8c8736676
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vmdevices/hostdevice.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/62064/1
diff --git a/vdsm/virt/vmdevices/hostdevice.py b/vdsm/virt/vmdevices/hostdevice.py
index bfd7f45..8e0290c 100644
--- a/vdsm/virt/vmdevices/hostdevice.py
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -40,6 +40,7 @@
self.hostAddress = self._deviceParams.get('address')
self.numa_node = self._deviceParams.get('numa_node', None)
self.name = self.device
+ self.is_hostdevice = True
def setup(self):
self.log.info('Detaching device %s from the host.' % self.device)
@@ -156,6 +157,7 @@
self.hostAddress = device_params.get('address')
self.numa_node = None
self.name = self.device
+ self.is_hostdevice = True
def setup(self):
detach_detachable(self.device)
@@ -246,6 +248,7 @@
self.name = self.device
self.bus_address, self.adapter = scsi_address_to_adapter(
self.hostAddress)
+ self.is_hostdevice = True
def setup(self):
detach_detachable(self.device)
--
To view, visit https://gerrit.ovirt.org/62064
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4b70f698fb1e6d8a8adec650d5a91d8c8736676
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: devices: add is_hostdevice attribute
by Martin Polednik
Martin Polednik has uploaded a new change for review.
Change subject: devices: add is_hostdevice attribute
......................................................................
devices: add is_hostdevice attribute
is_hostdevice attribute is currently used to determine whether given
device is so called host device, or in other words if it refers to
physical device.
At the moment, only devices HOSTDEV and NETWORK may be host devices,
but moving the attribute to interface level allows us to greatly
simplify host NUMA scheduling.
Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vmdevices/core.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/62063/1
diff --git a/vdsm/virt/vmdevices/core.py b/vdsm/virt/vmdevices/core.py
index 1508b9d..90b8cd8 100644
--- a/vdsm/virt/vmdevices/core.py
+++ b/vdsm/virt/vmdevices/core.py
@@ -36,7 +36,8 @@
class Base(vmxml.Device):
__slots__ = ('deviceType', 'device', 'alias', 'specParams', 'deviceId',
- 'conf', 'log', '_deviceXML', 'type', 'custom')
+ 'conf', 'log', '_deviceXML', 'type', 'custom',
+ 'is_hostdevice')
def __init__(self, conf, log, **kwargs):
self.conf = conf
@@ -50,6 +51,7 @@
self.log.debug('Ignoring param (%s, %s) in %s', attr, value,
self.__class__.__name__)
self._deviceXML = None
+ self.is_hostdevice = False
def __str__(self):
attrs = [':'.join((a, str(getattr(self, a, None)))) for a in dir(self)
--
To view, visit https://gerrit.ovirt.org/62063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: hostdev: expose numa_node in host device
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
......................................................................
Patch Set 16:
* update_tracker: OK
* Set MODIFIED::bug 1356161::::#1356161::::IGNORE, not all related patches are closed, check 60640
--
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4584b99dfbff8b2e61f4f73ad58e3b67bf0c55ce
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 8 months
Change in vdsm[master]: hostdev: expose numa_node in host device
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: expose numa_node in host device
......................................................................
hostdev: expose numa_node in host device
Change-Id: I4584b99dfbff8b2e61f4f73ad58e3b67bf0c55ce
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356161
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/60638
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vmdevices/hostdevice.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4584b99dfbff8b2e61f4f73ad58e3b67bf0c55ce
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months