Change in vdsm[master]: hostdev: report device MMIO numa node
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
......................................................................
Patch Set 16:
* #60637::Update tracker: OK
* #1356161::Update tracker: OK
* Set MODIFIED::bug 1356161::::#1356161::::IGNORE, not all related patches are closed, check 60638
--
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2995b68465caa52f6c721ed5af7d537748fa647a
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 7 months
Change in vdsm[master]: hostdev: report device MMIO numa node
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: report device MMIO numa node
......................................................................
hostdev: report device MMIO numa node
MMIO, or memory mapped IO, is a method of performing device IO via
memory mapping. On NUMA aware systems, such memory region resides on
of the host's NUMA nodes.
For each PCI device, we report the region's NUMA node affinity to
better schedule VM numa affinity further in the patch series.
Change-Id: I2995b68465caa52f6c721ed5af7d537748fa647a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356161
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/60637
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/hostdev.py
M tests/devices/data/pci_0000_00_02_0.xml
M tests/devices/data/pci_0000_05_00_1.xml
M tests/devices/data/pci_0000_05_10_7.xml
M tests/hostdevTests.py
5 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2995b68465caa52f6c721ed5af7d537748fa647a
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in vdsm[master]: core: Introduce new Volume.getWatermarks verb
by ahino＠redhat.com
Ala Hino has uploaded a new change for review.
Change subject: core: Introduce new Volume.getWatermarks verb
......................................................................
core: Introduce new Volume.getWatermarks verb
This verb returns the volume watermarks and will be used in two cases:
1. Before merge in order to extend the base volume size to minimal
required size
2. After merge in order to reduce volume size to optimal
Change-Id: I9f1feeb1540b2cb887b431b8075c26da09b62ea8
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M lib/api/vdsm-api.yml
M vdsm/API.py
M vdsm/storage/hsm.py
3 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/64451/1
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 0ef9f22..c27b6fa 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -9675,6 +9675,29 @@
description: A task UUID
type: *UUID
+Volume.getWatermarks:
+ added: '4.1'
+ description: Returns the volume watermarks.
+ params:
+ - description: The Storage Pool associated with the Volume
+ name: storagepoolID
+ type: *UUID
+
+ - description: The Storage Domain associated with the Volume
+ name: storagedomainID
+ type: *UUID
+
+ - description: The Image associated with the Volume
+ name: imageID
+ type: *UUID
+
+ - description: The UUID of the Volume
+ name: volumeID
+ type: *UUID
+ return:
+ description: The volume size info
+ type: *VolumeSizeInfo
+
Volume.getInfo:
added: '3.1'
description: Get information about a Volume.
diff --git a/vdsm/API.py b/vdsm/API.py
index 7922c76..e46a3fc 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -871,6 +871,10 @@
return self._irs.reduceVolumeSize(
self._spUUID, self._sdUUID, self._imgUUID, self._UUID, newSize)
+ def getWatermarks(self):
+ return self._irs.getVolumeWatermarks(
+ self._spUUID, self._sdUUID, self._imgUUID, self._UUID)
+
def updateSize(self, newSize):
return self._irs.updateVolumeSize(
self._spUUID, self._sdUUID, self._imgUUID, self._UUID, newSize)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 881165f..67bea22 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -667,6 +667,11 @@
raise NotImplementedError
@public
+ def getVolumeWatermarks(self, spUUID, sdUUID, imgUUID, volUUID,
+ options=None):
+ raise NotImplementedError
+
+ @public
def updateVolumeSize(self, spUUID, sdUUID, imgUUID, volUUID, newSize):
"""
Update the volume size with the given newSize (in bytes).
--
To view, visit https://gerrit.ovirt.org/64451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f1feeb1540b2cb887b431b8075c26da09b62ea8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: core: Introduce new Volume.reduceSize verb
by ahino＠redhat.com
Ala Hino has uploaded a new change for review.
Change subject: core: Introduce new Volume.reduceSize verb
......................................................................
core: Introduce new Volume.reduceSize verb
This new verb will be used after merge to reduce volume size to optimal.
Change-Id: If4e1fadda1aa34274e568bcaae7ba1f8b350a48f
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M lib/api/vdsm-api.yml
M vdsm/API.py
M vdsm/storage/hsm.py
3 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/64450/1
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 0745093..0ef9f22 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -9648,6 +9648,33 @@
description: A task UUID
type: *UUID
+Volume.reduceSize:
+ added: '4.1'
+ description: Reduces the virtual size of a volume.
+ params:
+ - description: The Storage Pool associated with the Volume
+ name: storagepoolID
+ type: *UUID
+
+ - description: The Storage Domain associated with the Volume
+ name: storagedomainID
+ type: *UUID
+
+ - description: The Image associated with the Volume
+ name: imageID
+ type: *UUID
+
+ - description: The UUID of the Volume
+ name: volumeID
+ type: *UUID
+
+ - description: The new desired size (in bytes)
+ name: newSize
+ type: string
+ return:
+ description: A task UUID
+ type: *UUID
+
Volume.getInfo:
added: '3.1'
description: Get information about a Volume.
diff --git a/vdsm/API.py b/vdsm/API.py
index 267aad7..7922c76 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -867,6 +867,10 @@
return self._irs.extendVolumeSize(
self._spUUID, self._sdUUID, self._imgUUID, self._UUID, newSize)
+ def reduceSize(self, newSize):
+ return self._irs.reduceVolumeSize(
+ self._spUUID, self._sdUUID, self._imgUUID, self._UUID, newSize)
+
def updateSize(self, newSize):
return self._irs.updateVolumeSize(
self._spUUID, self._sdUUID, self._imgUUID, self._UUID, newSize)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index faf3dfb..881165f 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -663,6 +663,10 @@
imgUUID, volUUID, newSizeSectors)
@public
+ def reduceVolumeSize(self, spUUID, sdUUID, imgUUID, volUUID, newSize):
+ raise NotImplementedError
+
+ @public
def updateVolumeSize(self, spUUID, sdUUID, imgUUID, volUUID, newSize):
"""
Update the volume size with the given newSize (in bytes).
--
To view, visit https://gerrit.ovirt.org/64450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4e1fadda1aa34274e568bcaae7ba1f8b350a48f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: sdm: Introduce new SDM.merge verb
by ahino＠redhat.com
Ala Hino has uploaded a new change for review.
Change subject: sdm: Introduce new SDM.merge verb
......................................................................
sdm: Introduce new SDM.merge verb
This API is another data operation separate from SPM. It merges data
from top volume to base volume and it replaces the existing
'mergeSnapshots' verb.
This verb will be used in the new cold merge flow:
1. Extend base volume (runs on the SPM)
2. Merge (runs on any host)
3. Shrink base volume to optimal size (runs on the SPM)
Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M lib/api/vdsm-api.yml
M vdsm/API.py
M vdsm/storage/hsm.py
3 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/64196/1
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index c7ab7f5..0745093 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -9905,3 +9905,19 @@
- description: The destination endpoint
name: destination
type: *CopyDataEndpoint
+
+SDM.merge:
+ added: '4.1'
+ description: Merge data from top volume to base volume.
+ params:
+ - description: A UUID to be used for tracking the job progress
+ name: job_id
+ type: *UUID
+
+ - description: The base volume
+ name: base
+ type: *CopyDataDivEndpoint
+
+ - description: The top volume
+ name: top
+ type: *CopyDataDivEndpoint
diff --git a/vdsm/API.py b/vdsm/API.py
index f000297..267aad7 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1636,3 +1636,6 @@
def copy_data(self, job_id, source, destination):
return self._irs.sdm_copy_data(job_id, source, destination)
+
+ def merge(self, job_id, base, top):
+ return self._irs.sdm_merge(job_id, base, top)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index d1b50d2..faf3dfb 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3530,3 +3530,7 @@
job = sdm.api.copy_data.Job(job_id, self._get_hostid(),
source, destination)
self.sdm_schedule(job)
+
+ @public
+ def sdm_merge(self, job_id, base, top):
+ raise NotImplementedError
--
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: virt: Make boolean values from boolean migration options
by mzamazal＠redhat.com
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make boolean values from boolean migration options
......................................................................
virt: Make boolean values from boolean migration options
`compressed' and `autoConverge' migration options have boolean values in
the string form. They must be converted to actual booleans before they
are checked.
Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Bug-Url: https://bugzilla.redhat.com/1380822
Backport-To: 4.0
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M vdsm/virt/migration.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65007/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index bed481e..3f51c89 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -111,8 +111,8 @@
kwargs.get('maxBandwidth') or
config.getint('vars', 'migration_max_bandwidth')
)
- self._autoConverge = autoConverge
- self._compressed = compressed
+ self._autoConverge = utils.tobool(autoConverge)
+ self._compressed = utils.tobool(compressed)
self._incomingLimit = kwargs.get('incomingLimit')
self._outgoingLimit = kwargs.get('outgoingLimit')
self.status = {
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: acceptor: stop to double close acceptor
by Piotr Kliczewski
Piotr Kliczewski has uploaded a new change for review.
Change subject: acceptor: stop to double close acceptor
......................................................................
acceptor: stop to double close acceptor
When reactor is stopped it closes all dispatchers so there is no need to
close acceptor one more time.
Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/protocoldetector.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/63685/1
diff --git a/lib/vdsm/protocoldetector.py b/lib/vdsm/protocoldetector.py
index 196a2ab..40f3c0d 100644
--- a/lib/vdsm/protocoldetector.py
+++ b/lib/vdsm/protocoldetector.py
@@ -208,7 +208,6 @@
def stop(self):
self.log.debug("Stopping Acceptor")
self._reactor.stop()
- self._acceptor.close()
class _CannotDetectProtocol(Exception):
--
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
7 years, 7 months
Change in vdsm[master]: net libvirt ovs: sync libvirt with running_config
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: net libvirt ovs: sync libvirt with running_config
......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/65096
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20314c3899796bc87b441894a24c382e46458e2a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 7 months
Change in vdsm[master]: Revert "virt net: Change graphics type from network to address"
by phoracek＠redhat.com
Petr Horáček has uploaded a new change for review.
Change subject: Revert "virt net: Change graphics type from network to address"
......................................................................
Revert "virt net: Change graphics type from network to address"
Now we save even OVS networks in libvirt database. This change is
not needed anymore.
TODO: get rid of migration hooking
This reverts commit 114e4805196f200f894d70c75cc4a001430f7bc4.
Change-Id: I1683997318df0188bc180328af15282ed2099ed0
---
M vdsm/virt/vmdevices/graphics.py
1 file changed, 5 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/65098/1
diff --git a/vdsm/virt/vmdevices/graphics.py b/vdsm/virt/vmdevices/graphics.py
index 62a1868..0b441e2 100644
--- a/vdsm/virt/vmdevices/graphics.py
+++ b/vdsm/virt/vmdevices/graphics.py
@@ -18,9 +18,10 @@
# Refer to the README and COPYING files for full details of the license
#
+import logging
+
import libvirt
-from vdsm import supervdsm
from vdsm.network import api as net_api
from vdsm import utils
from vdsm.config import config
@@ -140,17 +141,7 @@
graphics.appendChildWithArgs('channel', name=chan,
mode='secure')
- # For the listen type IP to be used, the display network must be OVS.
- # We assume that the cluster in which the host operates is OVS enabled
- # and all other hosts in the cluster have the migration hook installed.
- # The migration hook is responsible to convert ip to net and vice versa
- display_network = self.specParams.get('displayNetwork')
- display_ip = self.specParams.get('displayIp', '0')
- if (display_network and display_ip != '0' and
- supervdsm.getProxy().ovs_bridge(display_network)):
- graphics.appendChildWithArgs(
- 'listen', type='address', address=display_ip)
- elif display_network:
+ if self.specParams.get('displayNetwork'):
graphics.appendChildWithArgs(
'listen', type='network',
network=net_api.netname_o2l(
@@ -220,16 +211,11 @@
def _getNetworkIp(network):
try:
nets = net_api.libvirt_networks()
- # On a legacy based network, the device is the iface specified in the
- # network report (supporting real bridgeless networks).
- # In case the report or the iface key is missing,
- # the device is defaulted to the network name (i.e. northbound port).
- device = (nets[network]['iface'] or network
- if network in nets else network)
+ device = nets[network]['iface'] or network
ip, _, _, _ = net_api.ip_addrs_info(device)
except (libvirt.libvirtError, KeyError, IndexError):
ip = config.get('addresses', 'guests_gateway_ip')
- finally:
if ip == '':
ip = '0'
+ logging.info('network %s: using %s', network, ip)
return ip
--
To view, visit https://gerrit.ovirt.org/65098
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1683997318df0188bc180328af15282ed2099ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: net libvirt ovs: sync libvirt with running_config
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: net libvirt ovs: sync libvirt with running_config
......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/65096
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20314c3899796bc87b441894a24c382e46458e2a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 7 months