June 2016 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: ppc64hwinfo: add tests for getHardwareInfoStructure

by fromani＠redhat.com

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure ...................................................................... Patch Set 3: Code-Review+2 +2 because this is shared code, but in virt flow. -- To view, visit https://gerrit.ovirt.org/57748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86853a7f475c371581dc51d2d6426daeb10082fe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: ppc64hwinfo: make _getFromDeviceTree testable

by fromani＠redhat.com

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: make _getFromDeviceTree testable ...................................................................... Patch Set 3: Code-Review+2 this change is covered by tests add in a later patch, but looks trivial. +2 because this is shared code, but in virt flow. -- To view, visit https://gerrit.ovirt.org/57745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I722de9b7d6477e8edbc733ed3ee5b65fdaada325 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: ppc64hwinfo: make getHardwareInfoStructure testable

by fromani＠redhat.com

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: make getHardwareInfoStructure testable ...................................................................... Patch Set 3: this change is covered by tests add in a later patch, but looks trivial. +2 because this is shared code, but in virt flow. -- To view, visit https://gerrit.ovirt.org/57747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f7012fbefacf7a8d3a91bc86520c9ac6d82fb09 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: ppc64hwinfo: make getHardwareInfoStructure testable

by fromani＠redhat.com

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: make getHardwareInfoStructure testable ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f7012fbefacf7a8d3a91bc86520c9ac6d82fb09 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

by fromani＠redhat.com

Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree ...................................................................... Patch Set 3: Code-Review-1 (1 comment) changing score for visibility only https://gerrit.ovirt.org/#/c/57746/3/tests/hwinfo_test.py File tests/hwinfo_test.py: Line 29: from vdsm import ppc64HardwareInfo Line 30: Line 31: Line 32: @expandPermutations Line 33: class TestHwinfo(VdsmTestCase): Since here you're testing private methods, please add a TODO to document that we are doing this only for short-term convenience, and that we should do further refactoring and add better testing to remove this in the future Line 34: Line 35: @permutations([ Line 36: [b'abc', 'abc'], Line 37: [b'abc\0', 'abc'], -- To view, visit https://gerrit.ovirt.org/57746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id589267feafafd14846c1d38a850e0a79ae8e0d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: net: Report the default gateway flag through caps

by edwardh＠redhat.com

Edward Haas has posted comments on this change. Change subject: net: Report the default gateway flag through caps ...................................................................... Patch Set 7: Verified+1 Unit and Functional tests are passing -- To view, visit https://gerrit.ovirt.org/58351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dfbdd71310cbbb672a185e2f1ac6fdd9b495906 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: net: Report the default gateway flag through caps

by automation＠ovirt.org

gerrit-hooks has posted comments on this change. Change subject: net: Report the default gateway flag through caps ...................................................................... Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dfbdd71310cbbb672a185e2f1ac6fdd9b495906 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: rpc: Log RPC call summary on info level

by Nir Soffer

Nir Soffer has posted comments on this change. Change subject: rpc: Log RPC call summary on info level ...................................................................... Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59080/3/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 505: self._do_serveRequest(ctx, req) Line 506: self.log.info("RPC call of %s finished; %s seconds", Line 507: req.method, monotonic_time() - start_time) Line 508: Line 509: def _do_serveRequest(self, ctx, req): > > You uglified the code to add logging, and this is not the code that we ar Considering the response code, this is not a good match for utils.stopwatch. Line 510: self._attempt_log_stats() Line 511: logLevel = logging.DEBUG Line 512: Line 513: # VDSM should never respond to any request before all information about -- To view, visit https://gerrit.ovirt.org/59080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: rpc: Log important info from VM stats

by Nir Soffer

Nir Soffer has posted comments on this change. Change subject: rpc: Log important info from VM stats ...................................................................... Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py File vdsm/API.py: Line 1344: """ Line 1345: hooks.before_get_all_vm_stats() Line 1346: statsList = self._cif.getAllVmStats() Line 1347: statsList = hooks.after_get_all_vm_stats(statsList) Line 1348: self._allvmstats_log.log(self.log, logging.DEBUG, > This code should not be here. Why not to have it in self._cif.getAllVmStats Probably because the hook can modify statsList Line 1349: "Current getAllVmStats: %s", Line 1350: AllVmStatsValue(statsList)) Line 1351: return {'status': doneCode, 'statsList': Suppressed(statsList)} Line 1352: -- To view, visit https://gerrit.ovirt.org/58465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: API: logging: move setLogLevel code into logUtils

by automation＠ovirt.org

gerrit-hooks has posted comments on this change. Change subject: API: logging: move setLogLevel code into logUtils ...................................................................... Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacda9f82c6e0bc22a19403b99acbfffbdb7fd2bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 12 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches June 2016