June 2016 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: API: logging: set level to logger, not to handler

by automation＠ovirt.org

gerrit-hooks has posted comments on this change. Change subject: API: logging: set level to logger, not to handler ...................................................................... Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc0cc2d2a642633956439b9733228ab8811e8300 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: doc: Typo fixes in utils.monotonic_time docstring

by mzamazal＠redhat.com

Milan Zamazal has uploaded a new change for review. Change subject: doc: Typo fixes in utils.monotonic_time docstring ...................................................................... doc: Typo fixes in utils.monotonic_time docstring Change-Id: I0dc1560e81783a7c169896c235b043f50484cc97 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M lib/vdsm/utils.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/59295/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index e6b8dd5..6ffa33e 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -817,12 +817,12 @@ This function is useful if the client just needs to use the difference between two given time points. - With repect to time.time(): - * The resolution of this function is lower. On Linux, - the resolution is 1/_SC_CLK_TCK, which in turn depend on + With respect to time.time(): + * The resolution of this function is finer. On Linux, + the resolution is 1/_SC_CLK_TCK, which in turn depends on the value of HZ configured in the kernel. A commonly found resolution is 10 (ten) ms. - * This functions is resilient with respect to system clock + * This function is resilient with respect to system clock adjustments. """ return os.times()[4] -- To view, visit https://gerrit.ovirt.org/59295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0dc1560e81783a7c169896c235b043f50484cc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>

7 years, 12 months

4
11
0 / 0

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

by automation＠ovirt.org

gerrit-hooks has posted comments on this change. Change subject: hooks: openstack hook should wait a while for nic activation ...................................................................... Patch Set 2: * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1314371::OK, public bug * Check Product::#1314371::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: rpc: Log important info from VM stats

by Piotr Kliczewski

Piotr Kliczewski has posted comments on this change. Change subject: rpc: Log important info from VM stats ...................................................................... Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/58465/17/lib/vdsm/logUtils.py File lib/vdsm/logUtils.py: PS17, Line 28: import time Jenkins complains: ./lib/vdsm/logUtils.py:28: 'time' imported but unused -- To view, visit https://gerrit.ovirt.org/58465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: rpc: Log important info from VM stats

by Piotr Kliczewski

Piotr Kliczewski has posted comments on this change. Change subject: rpc: Log important info from VM stats ...................................................................... Patch Set 17: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py File vdsm/API.py: Line 1344: """ Line 1345: hooks.before_get_all_vm_stats() Line 1346: statsList = self._cif.getAllVmStats() Line 1347: statsList = hooks.after_get_all_vm_stats(statsList) Line 1348: self._allvmstats_log.log(self.log, logging.DEBUG, This code should not be here. Why not to have it in self._cif.getAllVmStats()? Line 1349: "Current getAllVmStats: %s", Line 1350: AllVmStatsValue(statsList)) Line 1351: return {'status': doneCode, 'statsList': Suppressed(statsList)} Line 1352: -- To view, visit https://gerrit.ovirt.org/58465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: rpc: Use Suppressed class instead of logging workarounds

by Nir Soffer

Nir Soffer has posted comments on this change. Change subject: rpc: Use Suppressed class instead of logging workarounds ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaf00e557fccb8f08fa3aeb38d51cb4bbe0ffe53 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: xmlrpc: Hide fenceNode password in the log

by michal.skrivanek＠redhat.com

Michal Skrivanek has posted comments on this change. Change subject: xmlrpc: Hide fenceNode password in the log ...................................................................... Patch Set 4: hey Toni, thanks for comments!:) Though let's just merge, it's about a fifth time we're arguing and delaying something which we are killing as the next step. Let's get to that one! -- To view, visit https://gerrit.ovirt.org/58833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: net: Report the default gateway flag through caps

by edwardh＠redhat.com

Edward Haas has posted comments on this change. Change subject: net: Report the default gateway flag through caps ...................................................................... Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/58351/6/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 4162: type: string Line 4163: Line 4164: - defaultvalue: no-default Line 4165: description: Whether the gateway is the host default Line 4166: name: ipv4defaultgateway > why don't we report it on vlan? Done Line 4167: type: boolean Line 4168: Line 4169: - defaultvalue: no-default Line 4170: description: Specify Switch. Legacy is used if not passed https://gerrit.ovirt.org/#/c/58351/6/vdsm_hooks/ovs/ovs_after_get_caps.py File vdsm_hooks/ovs/ovs_after_get_caps.py: Line 73: 'ipv6addrs': ipv6addrs, Line 74: 'ipv6autoconf': addresses.is_ipv6_local_auto(interface), Line 75: 'ipv6gateway': ipv6gateway, Line 76: 'dhcpv6': dhcpv6, Line 77: 'ipv4defaultgateway': netinfo_routes.is_default_gateway(gateway)} > ovs/info.py needs you as well! Done Line 78: Line 79: Line 80: def _get_ports(network, attrs): Line 81: """Return network's ports. Such ports consist of a port explicitly assigned -- To view, visit https://gerrit.ovirt.org/58351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dfbdd71310cbbb672a185e2f1ac6fdd9b495906 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: openstacknet: add MidoNet support

by mmirecki＠redhat.com

Marcin Mirecki has posted comments on this change. Change subject: openstacknet: add MidoNet support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5cb84c155b46603e05951238ad16182081dbe10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt(a)midokura.com> Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

7 years, 12 months

1
0
0 / 0

Change in vdsm[master]: ovs: edit bond mode

by edwardh＠redhat.com

Edward Haas has posted comments on this change. Change subject: ovs: edit bond mode ...................................................................... Patch Set 9: (1 comment) Just one nit https://gerrit.ovirt.org/#/c/58437/9/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: PS9, Line 228: bond_detect_mode = 'carrier' : bond_miimon_interval = None : if miimon is not None: : bond_detect_mode = 'miimon' : bond_miimon_interval = miimon if - else seems more appropriate. if miimon is None: ... else: -- To view, visit https://gerrit.ovirt.org/58437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9009933445c8bf162b236a2f9081e796d5f9272f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

7 years, 12 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches June 2016