Change in vdsm[master]: net: Cleanup - Convert netconfpersistence._getConfigs to sta...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Cleanup - Convert netconfpersistence._getConfigs to staticmethod
......................................................................
net: Cleanup - Convert netconfpersistence._getConfigs to staticmethod
Change-Id: Id85f8f17a1f7c111b435002d489addc431c0e0f6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id85f8f17a1f7c111b435002d489addc431c0e0f6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net: Cleanup - Convert netconfpersistence._getConfigs to sta...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Cleanup - Convert netconfpersistence._getConfigs to staticmethod
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85f8f17a1f7c111b435002d489addc431c0e0f6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: vm: network: paramsToBandwidthXML as staticmethod
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: network: paramsToBandwidthXML as staticmethod
......................................................................
vm: network: paramsToBandwidthXML as staticmethod
Since network.Interface.paramsToBandwidthXML use nothing of the
instance state, we turn it to a static method, and we rename it
to be pep8 friendlier.
No changes in behaviour.
Change-Id: Iaac88b4258cb5396e92631648af2b64a2350275c
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/network.py
M tests/device_test.py
M vdsm/virt/vm.py
3 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaac88b4258cb5396e92631648af2b64a2350275c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: vm: network: paramsToBandwidthXML as staticmethod
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: network: paramsToBandwidthXML as staticmethod
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaac88b4258cb5396e92631648af2b64a2350275c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: func helpers, net: Cleanup oVirt Node reference
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: func helpers, net: Cleanup oVirt Node reference
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/73609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32a9250a025fb0ed1a5c01027ff1503c6dad010b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: func helpers, net: Cleanup oVirt Node reference
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: func helpers, net: Cleanup oVirt Node reference
......................................................................
Patch Set 2:
this is very much like the dormant https://gerrit.ovirt.org/#/c/68023/
code seems fine; the interesting bit is the verification.
--
To view, visit https://gerrit.ovirt.org/73609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32a9250a025fb0ed1a5c01027ff1503c6dad010b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: tool: fix service_status in privileged containers
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: fix service_status in privileged containers
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/73251/1/lib/vdsm/tool/service.py
File lib/vdsm/tool/service.py:
Line 351: continue
Line 352: else:
Line 353: # BZ#1427527
Line 354: chroot_error = 'Running in chroot, ignoring request.' in err
Line 355: if rc == 0 and not chroot_error:
> which security permission did you set, and where?
running without systemd is something else and probably require to share different folders from the host to reach host's devices.. but to allow systemd as is to run in the container, I need to share /sys/fs/cgroup host's dir, and run with securityContext:privileged: true. I also set hostIPC: true, with that I didn't get this chroot issue. and I don't see host's network at all. vdsm service that runs there sees only the container's devices
Line 356: return 0
Line 357: else:
Line 358: raise ServiceOperationError(
Line 359: "%s failed" % alt.__name__, out, err)
--
To view, visit https://gerrit.ovirt.org/73251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc0cb06142297468a660ebe9171c8dde4fd480a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: spec net: During VDSM upgrade, reset vdsm-network service
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec net: During VDSM upgrade, reset vdsm-network service
......................................................................
spec net: During VDSM upgrade, reset vdsm-network service
vdsm-network is a systemd oneshot service which should be reloaded upon
vdsm upgrade.
Currently it performs two actions:
- Triggers the upgrade-unified-persistence process.
- Restoration of the persisted networks.
Both are already "protected" by flags that assure they run only once per
boot, therefore no logic is suppose to be change with this path.
Future patches will introduce additional (or replacement) actions that
will leverage systemd oneshot semantics, instead of internal flag
implementations.
Change-Id: Ib574a89d33fafccf9f4ceca13ff9dae17f51dcf8
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib574a89d33fafccf9f4ceca13ff9dae17f51dcf8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: tool: fix service_status in privileged containers
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: fix service_status in privileged containers
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/73251/1/lib/vdsm/tool/service.py
File lib/vdsm/tool/service.py:
Line 351: continue
Line 352: else:
Line 353: # BZ#1427527
Line 354: chroot_error = 'Running in chroot, ignoring request.' in err
Line 355: if rc == 0 and not chroot_error:
> I never got that when I set the right security permissions... for me it ret
which security permission did you set, and where?
We would like the networking code to run properly even if systemd is not running inside our container.
Line 356: return 0
Line 357: else:
Line 358: raise ServiceOperationError(
Line 359: "%s failed" % alt.__name__, out, err)
--
To view, visit https://gerrit.ovirt.org/73251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc0cb06142297468a660ebe9171c8dde4fd480a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: add dhclient to dependencies
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: add dhclient to dependencies
......................................................................
add dhclient to dependencies
While dhclient is usualy available in minimal server instalation,
it is not pre-installed inside container images.
Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months