Change in vdsm[master]: net: Properly initialize ConfigNetworkError exception
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Properly initialize ConfigNetworkError exception
......................................................................
net: Properly initialize ConfigNetworkError exception
Change-Id: I75e0979412b9d8baba2e6c18c3f19d70f827b075
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/errors.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75e0979412b9d8baba2e6c18c3f19d70f827b075
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net: Properly initialize ConfigNetworkError exception
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Properly initialize ConfigNetworkError exception
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75e0979412b9d8baba2e6c18c3f19d70f827b075
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: net tests: migrating testSetupNetworksAddManyVlans to the ne...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: migrating testSetupNetworksAddManyVlans to the new func tests
......................................................................
net tests: migrating testSetupNetworksAddManyVlans to the new func tests
Change-Id: I21418bc9b094ecfbc17cfbe5df9414ecfbac18f8
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
M tests/network/func_net_basic_test.py
2 files changed, 25 insertions(+), 31 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73243
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21418bc9b094ecfbc17cfbe5df9414ecfbac18f8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: rpmlint: silence warning about zero-length conf files
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: rpmlint: silence warning about zero-length conf files
......................................................................
rpmlint: silence warning about zero-length conf files
rpmlint does not like empty conf files, so we're shipping them with a
single newline.
Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-patch.sh
M static/etc/vdsm/mom.d/01-parameters.policy
M tests/toolTests_empty.conf
3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/73455/1
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index f7faf55..6bb0804 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -33,6 +33,6 @@
# TODO: fix spec to stop ignoring the few current errors
! rpmlint "$EXPORT_DIR/"!(*.src).rpm | grep ': E: ' | grep -v explicit-lib-dependency | \
- grep -v no-binary | grep -v zero-length | \
+ grep -v no-binary | \
grep -v non-readable | grep -v non-standard-dir-perm
fi
diff --git a/static/etc/vdsm/mom.d/01-parameters.policy b/static/etc/vdsm/mom.d/01-parameters.policy
index e69de29..8b13789 100644
--- a/static/etc/vdsm/mom.d/01-parameters.policy
+++ b/static/etc/vdsm/mom.d/01-parameters.policy
@@ -0,0 +1 @@
+
diff --git a/tests/toolTests_empty.conf b/tests/toolTests_empty.conf
index e69de29..8b13789 100644
--- a/tests/toolTests_empty.conf
+++ b/tests/toolTests_empty.conf
@@ -0,0 +1 @@
+
--
To view, visit https://gerrit.ovirt.org/73455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 2 months
Change in vdsm[master]: net tests: migrating testSetupNetworksAddManyVlans to the ne...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: migrating testSetupNetworksAddManyVlans to the new func tests
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73243
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21418bc9b094ecfbc17cfbe5df9414ecfbac18f8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: sr-iov: expose numa_node if available
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sr-iov: expose numa_node if available
......................................................................
sr-iov: expose numa_node if available
VDSM tries to find the best numa node for VM if host device exists.
Since the whole point of that feature is to eventually be available
for SR-IOV, Interface class should also expose it's numa_node.
Side effect is that since the code is checking *all* hostdevices
(including SR-IOV), using sr-iov+hostdev currently doesn't work.
Change-Id: I53094f8399d200b4dc92afb29f1c8ef9f8f47495
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1427202
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/network.py
M tests/device_test.py
2 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/73162
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53094f8399d200b4dc92afb29f1c8ef9f8f47495
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: network: remove is_hostdevice from __slots__
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: remove is_hostdevice from __slots__
......................................................................
network: remove is_hostdevice from __slots__
Already implemented by core.Base, doesn't need to be reimplemented.
Change-Id: I19b2eeda1e76c1076a9ecfd0945393c162a6148e
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/network.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/73232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19b2eeda1e76c1076a9ecfd0945393c162a6148e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net tests: Add grace/synchronization period for mode4 bonds.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
net tests: Add grace/synchronization period for mode4 bonds.
Although mode 4 bonds may be reported up, they may still not be fully
synchronized with their partner bond. The rate in which dedicated
packets are sent to the slaves is set/determined via the "lp_interval"
option -- wait the interval and some predetermined grace period to allow
the bonds to become synchronized with their partner bonds.
Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 21 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net tests: Add grace/synchronization period for mode4 bonds.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
Patch Set 23: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: net tests: Add grace/synchronization period for mode4 bonds.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
Patch Set 22: Code-Review-1
manual rebase required
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months