Change in vdsm[master]: virt: Limit migration recovery status to previously migratin...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Limit migration recovery status to previously migrating VMs
......................................................................
virt: Limit migration recovery status to previously migrating VMs
We introduced a check for running migrations in recovery. We utilize
migration.ongoing function for the check.
However migration.ongoing assumes that the domain has already been migrating to
another host, it doesn't work correctly in the general case, when we don't know
anything about the VM migration status in advance. The migration.ongoing check
is based on checking the presence of a domain job since there is no much better
way to check for ongoing migrations in libvirt. However the domain jobs are
not limited to host-to-host migrations, they can perform other tasks such as
hibernation or making a snapshot.
To satisfy the assumption of migration.ongoing we check for MIGRATION_SOURCE
status in recovery.
Change-Id: I37ce91f9490206fe2c68504dd17aa4326764d6ed
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/72703
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37ce91f9490206fe2c68504dd17aa4326764d6ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: vdsm-client: add help message per namespace
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-client: add help message per namespace
......................................................................
vdsm-client: add help message per namespace
help message is now generated from vdsm schema
and provides information for constructing a command.
vdsm-client -h
usage: vdsm-client [-h] [-a HOST] [-p PORT] [--unsecure] [--timeout TIMEOUT]
[-f FILE]
namespace method [arg=value] ...
Namespaces:
namespace method [arg=value]
Host
Task
LVMVolumeGroup
Image
VM
Volume
StorageDomain
ISCSIConnection
StoragePool
SDM
Lease
vdsm-client Lease -h
usage: vdsm-client Lease [-h] method [arg=value] ...
optional arguments:
-h, --help show this help message and exit
Lease methods:
method [arg=value]
rebuild_leases Rebuild external leases index on storage domain
status Return the underlying sanlock lease status
info Return external lease information
delete Delete an external lease (only on the SPM host)
create Create an external lease (only on the SPM host)
vdsm-client Lease create -h
usage: vdsm-client Lease create [-h] [arg=value [arg=value ...]]
positional arguments:
arg=value lease: The lease to create
JSON representation:
{
"lease": {
"sd_id": "UUID",
"lease_id": "UUID"
}
}
optional arguments:
-h, --help show this help message and exit
Change-Id: Ia9a8a605394e21fe5cbb7c3ddbe67d07a7da0f5c
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsmclient/client.py
1 file changed, 61 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/68101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9a8a605394e21fe5cbb7c3ddbe67d07a7da0f5c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: tool: fix service_status in privileged containers
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: fix service_status in privileged containers
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/73251/1/lib/vdsm/tool/service.py
File lib/vdsm/tool/service.py:
Line 351: continue
Line 352: else:
Line 353: # BZ#1427527
Line 354: chroot_error = 'Running in chroot, ignoring request.' in err
Line 355: if rc == 0 and not chroot_error:
I never got that when I set the right security permissions... for me it returns the same output as running systemd on any system
Line 356: return 0
Line 357: else:
Line 358: raise ServiceOperationError(
Line 359: "%s failed" % alt.__name__, out, err)
--
To view, visit https://gerrit.ovirt.org/73251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc0cb06142297468a660ebe9171c8dde4fd480a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: vdsmapi: get complex type representation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsmapi: get complex type representation
......................................................................
vdsmapi: get complex type representation
vdsm-api contain some complex method prameter types.
vdsm-client should use vdsmapi.py knowledge of the schema
in order to help the users construct these parameters.
vdsmapi now returns a dictionary represenation of
given command parameters.
keys represent the parameter names and dict values are
the parameter types.
Note that it's almost perfect: union types aren't fully
represented and only the union types are being stored.
usage:
from vdsm.api import vdsmapi
schema_paths = [vdsmapi.find_schema()]
schema = vdsmapi.Schema(schema_paths, False)
schema.get_args_dict("Lease", "create")
{
"lease": {
"sd_id": "UUID",
"lease_id": "UUID"
}
}
Change-Id: I25a9ace931b377408ffabb2b570af9da7cfccfc6
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/api/vdsmapi.py
M tests/vdsmapi_test.py
2 files changed, 112 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/73172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25a9ace931b377408ffabb2b570af9da7cfccfc6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: v2v: prevent importing of VMware VMs with snapshot
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: prevent importing of VMware VMs with snapshot
......................................................................
v2v: prevent importing of VMware VMs with snapshot
Since v2v doesn't support importing of VMs with snapshot(s), then we need
to avoid importing those VMs.
Since for Xen there is no libvirt API implemented for checking if
snapshots exist and for 'OVA from VMware' and KVM - the VM is imported
after all snapshots are collapsed, then the only external provider left
to handle is VMware.
Before this fix, trying to import a VMware VM with snapshot caused the import
to fail while trying to locate the current snapshot delta invalid vmdk disk name for
copying.
This solution handle this by skipping those VMS and writing an error to log.
Skipping means avoid sending the full info (XML, disks, network info etc) on those
VMs to the engine and therefore avoid displaying them in v2v second dialog
for importing.
Change-Id: Ic88a918aac2a1943aad8f6cf0a67daf5f2f9accc
Bug-Url: https://bugzilla.redhat.com/1336840
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M lib/vdsm/v2v.py
M tests/v2v_test.py
M tests/v2v_testlib.py
3 files changed, 34 insertions(+), 8 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72720
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic88a918aac2a1943aad8f6cf0a67daf5f2f9accc
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: net: Remove ipv4 prefix normalization from kernelconfig
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Remove ipv4 prefix normalization from kernelconfig
......................................................................
net: Remove ipv4 prefix normalization from kernelconfig
IPv4 prefix normalization is already performed at the canonicalize step,
there is no need to do it at kernelconfig normalization.
It is not expected for both netmask and prefix to exist in the
configuration and with this patch we embrace the canonicalize logic of
failing when both exists.
Change-Id: Ia3c5f9ee1c84d0113d2ecb3e2055785f7290f8b6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/kernelconfig.py
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c5f9ee1c84d0113d2ecb3e2055785f7290f8b6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: net: Move bond slaves normalization to canonicalize step
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Move bond slaves normalization to canonicalize step
......................................................................
net: Move bond slaves normalization to canonicalize step
Change-Id: I9e98c7c8907cb379fd0728a397e15d8fe03df464
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/kernelconfig.py
2 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e98c7c8907cb379fd0728a397e15d8fe03df464
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: net: Cleanup unused config net attrs filter fields
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Cleanup unused config net attrs filter fields
......................................................................
net: Cleanup unused config net attrs filter fields
When adding a network to a config (running/persistent), some fields have
been filtered out. This a hack used to adjust the code to the caller
usage.
This patch removes fields that are no longer in use by the callers,
therefore there is no need to filter them out.
Change-Id: I84f88d79cfa152f548334e6d3aed0d983999eb75
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 8 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84f88d79cfa152f548334e6d3aed0d983999eb75
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: net: Move dhcp config normalization to canonicalize step
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Move dhcp config normalization to canonicalize step
......................................................................
net: Move dhcp config normalization to canonicalize step
Change-Id: Iad3cc1a0d7c06fc33b6c4c0526459e9e2516b2bd
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/kernelconfig.py
2 files changed, 6 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad3cc1a0d7c06fc33b6c4c0526459e9e2516b2bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: net: On rollback failure clean running config from removed nets
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: On rollback failure clean running config from removed nets
......................................................................
net: On rollback failure clean running config from removed nets
When a setup failure occurs during rollback, some networks may have been
already removed, therefore, this state needs to be expressed in the
persisted running config.
Change-Id: I90866aac87d22745347a711de1fe1c540724fee7
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90866aac87d22745347a711de1fe1c540724fee7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month