Dan Kenigsberg has posted comments on this change.
Change subject: BZ#769502 Do not use lvm to get lv size if lv is active
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
just a little question
....................................................
File vdsm/storage/blockVolume.py
Line 85: if lvm.isLVActive(sdobj.sdUUID, volUUID):
why do you bother to test isLVActive? just try to _getDviceSize and get ENOENT if the lv
is inactive.
--
To view, visit
http://gerrit.ovirt.org/677
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e81bf563f07119a775888d6abc3c81f4f7b86a0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>