Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Removing update of 'node.startup' setting in
'addIscsiPortal'
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/iscsi.py
Line 181:     portalStr = "%s:%d" % (portal.hostname, portal.port)
Line 182: 
Line 183:     with _iscsiadmTransactionLock:
Line 184:         iscsiadm.discoverydb_new(discoverType, iface.name, portalStr)
Line 185: 
Wouldn't it be better to fix it? Why we don't need this anymore? (beside that it
was failing since some time)
Line 186:         try:
Line 187:             # Push credentials
Line 188:             if credentials is not None:
Line 189:                 for key, value in credentials.getIscsiadmOptions():


-- 
To view, visit http://gerrit.ovirt.org/17212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server