Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
......................................................................
Patch Set 13:
Previous message was cut short.
Patch Set 13: Verified
Verification -
The /var/run/vdsm/netconf/ directory is updated correctly for the following flows:
1) Using the setupNetworks API
Adding a network, removing a network
Adding a network, removing a network that are on a bond
Editing a bond without attaching or detaching a network
Creating a bond and attaching a network
Creating a bond without attaching a network
Destroying a bond and the network on it
Destroying a bond, adding a network on one of the old NICs
Editing a network
Editing a network that's on a bond
2) Using the addNetwork verb directly:
Adding a network
Adding a network and a bond
3) Using delNetwork directly:
Removing a network
Removing a network on a bond (Destroying the bond)
4) Using editNetwork directly:
Changing a network's parameters
Changing a network from being on a NIC to being on a bond
Changing a network from being on a bond to being on a NIC
--
To view, visit
http://gerrit.ovirt.org/16699
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Šebek <psebek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server