Dan Kenigsberg has submitted this change and it was merged.
Change subject: sd: Remove unused variable and evil thread
......................................................................
sd: Remove unused variable and evil thread
If storage domain had a non-null start instance variable, we used to
start a thread stopping this stat object in __del__(!). Fortunately,
stat is always None, so we don't need to stop it.
Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/63520
Reviewed-by: Ala Hino <ahino(a)redhat.com>
Reviewed-by: Freddy Rolland <frolland(a)redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/sdm_indirection_tests.py
M vdsm/storage/sd.py
2 files changed, 0 insertions(+), 8 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/63520
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>