Mark Wu has posted comments on this change.
Change subject: MOM Integration
......................................................................
Patch Set 7:
Hi Dan,
Thanks a lot for the review. I am going to revise the patch as per your comments. And the
unittest will be included in next version too. The only problem needing more discussions
is that how mom interacts with vdsm. Currently, vdsm passes the vdsm internal instance of
clientIF to mom to enable mom call vdsm API functions defined in API.py. Let's think
MOM is kind of plugin for vdsm, then it would make sense that passing cif to mom. Without
cif, mom would have to interact with vdsm via xmlrpc. In that case, mom works like a
standalone application on system. So which idea do you like more? Any other suggestions?
Thanks!
--
To view, visit
http://gerrit.ovirt.org/2367
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>