Zhou Zheng Sheng has posted comments on this change.
Change subject: check the syntaxs of optional parameters in json schema
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Your patch is good. However there are some errors in the json schema file and your patch
exposes these errors, that's why Jenkins unit test failed to build. You can have a
look at the last part of the report
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/527/console .
I think you can use the technique proposed in this patch to find all the #optional missing
errors and fix them in the json schema, then rebase this patch on these fixes.
--
To view, visit
http://gerrit.ovirt.org/10446
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f92459ee8787780a54a510b6f8cc074fb2a235
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server