Francesco Romani has posted comments on this change.
Change subject: command: Store stdout and stderr to a log file
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59833/1//COMMIT_MSG
Commit Message:
PS1, Line 13: This change adds the possibility to store the stdout and stderr to a log
: file
Making it general seemed as a good idea. Especially since all the
stream re
It *is* a good idea IMHO, is just that in this very specific case the
price to pay is too high, because of the complexity we already have.
Again, I don't have strong feelings against this, but we need to involve infra if we
go this way, because I'd like to have it refactored before (not a thing you should do
in this series unless you really want :)), and AFAIR there is some planned work in this
area because this code is already too complex.
You mean that virt-v2v sends useful data to both streams or that it uses them too
liberally? Perhaps let's file a long-term bug to virt-v2v to have this streamlined,
while we have a short term fix.
--
To view, visit
https://gerrit.ovirt.org/59833
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a8b9afaa196729c8ab98f380a39833a9a0840cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes