Nir Soffer has posted comments on this change.
Change subject: jsonrpc: fd leak
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: jsonrpc: fd leak
Line 8:
Line 9: We need to make sure that there is no reference to objects which holds
Line 10: a socket because m2c closes socket when its object is garbage collected.
Do you mean that we used to keep the connection in the context object just for the client
address, and we can actually fetch the address and save it instead of holding the
connection?
So if I understand the patch correctly, now the context does not hold the connection, and
the fd is closed when nobody else is using the connection object, right?
Line 11:
Line 12: Bug-Url:
https://bugzilla.redhat.com/1256446
Line 13: Change-Id: Ib15cca4659553b320babf928b603a0a75013ba99
--
To view, visit
https://gerrit.ovirt.org/45615
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib15cca4659553b320babf928b603a0a75013ba99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes