Change in vdsm[master]: sd: Remove unused setMetadata

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: sd: Remove unused setMetadata
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/45613/6//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-11-15 14:21:54 +0200
Line 6: 
Line 7: sd: Remove unused setMetadata
Line 8: 
Line 9: All usages of sd setMetadata have been removed.
Which code that was calling setMetadata was removed?  can you point me to the relevant
patch?
Line 10: 
Line 11: Therefore, no longer needed.
Line 12: As a result, the backup directory for sd MD
Line 13: creation and default values are also removed.


https://gerrit.ovirt.org/#/c/45613/6/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 874
Line 875
Line 876
Line 877
Line 878
This does nothing, so it makes sense to remove.


Line 878
Line 879
Line 880
Line 881
Line 882
This does work, backing up last metadata to backup dir. Why do you want to remove this
code?


Line 882
Line 883
Line 884
Line 885
Line 886
And why do you want to remove this code, updating metadata on shared storage?!

Are you sure we don't call this code?


-- 
To view, visit https://gerrit.ovirt.org/45613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes