Ayal Baron has posted comments on this change.
Change subject: [REVIEW ONLY] Added Gluster file system management support.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/gluster/gluster_binding.py
Line 23: return ((gluster.volumeCreate, "glusterVolumeCreate"),
I'm not sure why we need this file.
First of all, it is not binding to any type of transport.
Second if all functions under gluster module should be exposed and there is a clear naming
convention then why manually iterate them here and not do it automatically?
If not all functions should be exposed then you can still decorate those that should in
the API file itself where it is clear it's exposed.
....................................................
File vdsm/gluster/gluster_cli.py
Line 48: if line.upper() == "NO VOLUMES PRESENT":
Does gLuster support localization? (i.e. could the output be in other languages?)
Is there any plan to add different return codes per message in gLuster?
--
To view, visit
http://gerrit.ovirt.org/2808
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>