Dan Kenigsberg has posted comments on this change.
Change subject: Drop single use inheritance
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File vdsm/vm.py
Line 1142: self.log = log
Line 1143: self._deviceXML = None
Line 1144:
Line 1145: def __str__(self):
Line 1146: attrs = [':'.join((a, str(getattr(self, a)))) for a in
dir(self)
Avoid calling str() as it explodes on Unicode values. %s is safer.
Line 1147: if not a.startswith('__')]
Line 1148: return ' '.join(attrs)
Line 1149:
Line 1150: def createXmlElem(self, elemType, deviceType, attributes=[]):
--
To view, visit
http://gerrit.ovirt.org/18351
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If781ab20110874e71ba16b60d1d5511a54914979
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes