Doron Fediuck has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
......................................................................
Patch Set 3:
Hi Royce,
Thanks for a very interesting work.
However, I'm afraid I'm missing a design, before we rush into the
implementation.
ie- why did you choose to implement capping via proportions?
I'm not saying it's wrong, but I'm looking for the reasoning as well as
interaction with other libvirt settings.
Implementation wise, why did you choose tuneParams['vcpu_period'] = 1000000 ?
Which problem does it solve?
I believe we should add emulator_quota and period as well to make sure we can control
non-vcpu threads as well.
Please use
http://wiki.ovirt.org/wiki/Sla/cpu-and-memory
to share your thoughts, so we get the bigger picture.
--
To view, visit
http://gerrit.ovirt.org/7492
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e02e09ef06ad6de45be75c3f2f913a3025750f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhu Bo <bozhu(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server