Francesco Romani has posted comments on this change.
Change subject: utils: Add changehash function for change detection
......................................................................
Patch Set 1:
neat!
The only thing that worries me is how Engine is supposed to use this value. I mean, it is
considered just as an opaque string that it is stored and checked for equality? If so it
doesn't really matter how long it is and how it looks like, and we can happily go
ahead.
As for the change itself solid +1.
--
To view, visit
http://gerrit.ovirt.org/33045
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No