Change in vdsm[master]: Add LibvirtDrive

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add LibvirtDrive
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 887:         self.diskelem = self._createDiskXML()
these two should better be local vars

....................................................
File vdsm/vm.py
Line 384:                     drv['cache'] =
self.conf['custom']['viodiskcache']
I'm not sure it is nice to start reporting "cache" in vdsm.list(), I'd
prefer this to be a local variable of the Drive object.

consider giving Drive a ref of .conf so it can peep into custom

--
To view, visit http://gerrit.ovirt.org/789
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37b40c6260612d60942037363deb9a24e46dad46
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;