Change in vdsm[master]: Move domain monitor out of sp.py
Dan Kenigsberg has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 17: (2 inline comments)
I did not review this too closely, but I do not want to delay this. feel free to submit.
....................................................
File vdsm/storage/hsm.py
Line 2586: self.log.warning("Failed to stop RepoStats
thread", exc_info=True)
comment out of date
....................................................
File vdsm/storage/sp.py
Line 1284: code = 200
se.GeneralException.code is so much catchier than 200
yeah, I now see it in the original. still git would blame this commit.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com