Change in vdsm[master]: vm: Set numatune and guest numa topology

Adam Litke has posted comments on this change.

Change subject: vm: Set numatune and guest numa topology
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Thanks for the patch!  On the next submission I hope you will include the changes to
vdsmapi-schema.json so we can discuss the API a bit more thoroughly.

http://gerrit.ovirt.org/#/c/25254/1/vdsm/vm.py
File vdsm/vm.py:

Line 1136:             numa = XMLElement('numa')
Line 1137:             vmNumaTopology = self.conf.get('vmNumaTopology')
Line 1138:             for vmCell in vmNumaTopology:
Line 1139:                 numa.appendChildWithArgs('cell',
Line 1140:                                         
cpus=vmCell['cpus'].replace(";", ","),
Something seems strange here.  If you want commas, why not make them part of the format of
vmNumaTopology to begin with?  Maybe you need to model this a bit differently in the API.
Line 1141:                                          memory=vmCell['memory'])
Line 1142:             cpu.appendChild(numa)
Line 1143: 
Line 1144:         self.dom.appendChild(cpu)


Line 1157:             if ('nodeset' in numaMemory.keys()):
Line 1158:                 mode = 'strict'
Line 1159:                 if ('mode' in numaMemory.keys()):
Line 1160:                     mode = numaMemory['mode']
Line 1161:                 nodeset = numaMemory['nodeset'].replace(';',
',')
same comment about replacing ; with ,
Line 1162:                 numatune = XMLElement('numatune')
Line 1163:                 numatune.appendChildWithArgs('memory', mode=mode,
Line 1164:                                              nodeset=nodeset)
Line 1165:                 self.dom.appendChild(numatune)


-- 
To view, visit http://gerrit.ovirt.org/25254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes