Ayal Baron has posted comments on this change.
Change subject: [REVIEW ONLY] Added Gluster file system management support.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
I actually have multiple issues with the way gLuster is plugged into vdsm here. I believe
there should be a more generic way to add a plugin. I believe Saggi will start a
discussion about this upstream.
My problem is with the import if exists approach as well as the way exceptions are handled
in wrapApiMethod in the xmlrpc bindings etc.
I believe some refactoring is due here (the existing code is just not built for such a
thing)
--
To view, visit
http://gerrit.ovirt.org/2808
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>