Ondřej Svoboda has posted comments on this change.
Change subject: network.api: EL7's dhclient doesn't support -df so stop using it
temporarily
......................................................................
Patch Set 2: Verified+1
Tested on Fedora 22 with testDhcpReplaceNicWithBridge. I stepped through the new function
in a debugger and it correctly processed dhclient's "usage" output.
supports_duid_file returned True because it found "-df"; on EL7 it would return
False and never set duid_source on a bridge, so no network configurator would pass
"-df" to a dhclient.
--
To view, visit
https://gerrit.ovirt.org/45713
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia096d42d24b00e7ef075f1a2dde7e3a951c0b81c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No