Dan Kenigsberg has posted comments on this change.
Change subject: multipath: Move all calls to multipath exe to a single method
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/multipath.py
Line 112: supervdsm.getProxy().forceScsiScan()
Line 113:
Line 114: # Now let multipath daemon pick up new devices
Line 115:
Line 116: _runCmd("-r")
ever tested? [] + "-r" is bound to fail.
Line 117:
Line 118:
Line 119: def isEnabled():
Line 120: """
--
To view, visit
http://gerrit.ovirt.org/19255
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes