Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Refactor Pool.deleteImage()
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(13 inline comments)
....................................................
Commit Message
Line 7: BZ#788640 - Refactor Pool.deleteImage()
why?
....................................................
File vdsm/storage/sp.py
Line 1700: Deletes an Image folder with all it's volumes.
s/it's/its/
Line 1702: Assumed here that you have a name lock on imgUUID.
s/Assumed.*imgUUID./This function assumes that imgUUID is locked/
Line 1716: # TODO: Move this to .*SD class
why?
Line 1719: sdDom = sdCache.produce(sdUUID)
s/sdDom/dom/
Line 1722: imgsByVol = dict((k, v) for k, v in allVols.iteritems() if imgUUID in
v.imgs)
s/k/volName/
s/v/vol/
Line 1725: # or an unused template.
s/e.g..*/i.e. it's either an image which is not based on a template or a template
which has no derived images/
Line 1727: # if it is a template
no need for this comment
Line 1732: ts = tuple((k, v.imgs) for k, v in imgsByVol.iteritems() if
len(v.imgs) > 1)
s/ts/templateVol/
s/k/volName/
s/v/vol/
Line 1741: tSelfImage = tImgs[0]
s/tSelfImage/templateImage/
Line 1744: # Removing a template based image
s/a template based image/an image based on a template/
Line 1751: elif force:
seems odd that we support this. does engine ever use this? if not, I'd rather prevent
this with current images?
Line 1761: tPars = sdDom.produceVolume(imgUUID, tName).getVolumeParams()
s/tPars/tParams/
--
To view, visit
http://gerrit.ovirt.org/3464
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc1397c69c7ffa835abe0747b6573d56bb9d74e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>