From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Adding grub2-tool requirement which host-deploy requires
......................................................................
Patch Set 2: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/69462/2//COMMIT_MSG
Commit Message:
Line 7: Adding grub2-tool requirement which host-deploy requires
Line 8:
Line 9: In some environments this package is not installed by default, and
Line 10: is needed to allow running:
Line 11: "/sbin/grubby --update-kernel DEFAULT" which host-deploy uses.
host-deploy installs vdsm (and other ovirt related packages) on the
host an
you can add this package to src/plugins/ovirt-host-deploy/kernel/kernel.py
That o-h-d module needs grubby, so it should include its dependent package in
stage=plugin.Stages.STAGE_PACKAGES.
That is the puritan way.
Line 12:
Line 13: Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
--
To view, visit
https://gerrit.ovirt.org/69462
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes