Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
......................................................................
Patch Set 2:
(1 comment)
....................................................
File client/vdsClient.py
Line 246: return self.ExecAndExit(self.s.hotunplugDisk(params))
Line 247:
Line 248: def hotplugHostdev(self, args):
Line 249: params = {'vmId': args[0], 'hostdevName': args[1]}
Line 250: return self.ExecAndExit(self.s.hotplugNic(params))
noted, will be fixed in next patchset (same for below)
Line 251:
Line 252: def hotunplugHostdev(self, args):
Line 253: params = {'vmId': args[0], 'hostdevName': args[2]}
Line 254: return self.ExecAndExit(self.s.hotunplugNic(params))
--
To view, visit
http://gerrit.ovirt.org/22523
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fbf4a1d62789d9404e5977eb7eb01b17a1a43fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes