Juan Hernandez has posted comments on this change.
Change subject: Handle correctly nic names like p33p1.
......................................................................
Patch Set 1:
Dan, I found the issue in Fedora 16, using the RPMS prepared by Federico. I think that the
issue will be exactly the same in RHEL, but I didn't test it. Do you want me to open
the bug for Fedora or for RHEL?
The nicSort method wants to extract the name ("eth" from "eth0") and
the number ("0" from "eth0") from nic names in order to sort them by
name. If a name like "p33p1" is given then it will extract "p" and
"33". Later the same method rebuilds the nic concatenating the name and the
number, this results in "p33" in my case.
I added ^ and $ anchors to the regular expression used, to make sure that names like
"p33p1" will not match and will not be split/rebuilt incorrectly.
--
To view, visit
http://gerrit.ovirt.org/799
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I716f5d7d137325abaa0022a40f482c9ad270855a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>