Dan Kenigsberg has posted comments on this change.
Change subject: Use SANLock for the SPM resource
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File vdsm/storage/safelease.py
Line 26: import sanlock
sanlock is not (yet) in python's stdlib, contextlib is.
....................................................
File vdsm/vdsmd.init.in
Line 35: NEEDED_SERVICES="iscsid multipathd ntpd wdmd sanlock"
wdmd?!
Do you intentionally not require python-sanlock?
--
To view, visit
http://gerrit.ovirt.org/726
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>