Change in vdsm[master]: tox: added disable tox style validation option to Makefile

Yaniv Bronhaim has posted comments on this change.

Change subject: tox: added disable tox style validation option to Makefile
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/59417/2//COMMIT_MSG
Commit Message:

Line 10: variable that disables tox run.
Line 11: This option is useful for developers who encounter issues running tox
Line 12: on their environment and want to skip tox style validation.
Line 13: use it by the following:
Line 14: make check DISABLE_STYLE_VALIDATION=1
>  Why do we need to disable style check? 
make check can be equal
to make unittests, as it runs recursively check-local in each make file.
In addition to that, we have check-recursive rule -  check-recursive: gitignore
abs_imports python3 pyflakes pep8

we can remove that, but then users will need to call make pep8 pyflakes specifically .. I
still want to keep it in make check. If somehow (she or he) intentionally wants to disable
those checks (internet connection issues or whatever such as edy had), it will be
available by setting the DISABLE_STYLE_VALIDATION flag. imo it fits more to our desire -
each make will try to use and validate our tox jobs, unless specified otherwise.
Line 15: 
Line 16: Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571


-- 
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes