Francesco Romani has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
......................................................................
Patch Set 21:
(1 comment)
http://gerrit.ovirt.org/#/c/25978/21/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 342: runnable.start()
Line 343: try:
Line 344: yield runnable
Line 345: finally:
Line 346: runnable.stop()
Now when this generic utility, why not move it to lib/vdsm/utils.py?
Done
Line 347:
Line 348:
Line 349: class MonitorThread(threading.Thread):
Line 350: _MONITOR_TICK = 1.0 # unit: seconds
--
To view, visit
http://gerrit.ovirt.org/25978
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes