Ayal Baron has posted comments on this change.
Change subject: getDeviceList - passing includePartitioned to HSM
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File AUTHORS
Line 29: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
please remove trailing spaces
....................................................
File vdsm_cli/vdsClient.py
Line 549: options = self._parseDriveSpec(args[1]) if len(args) > 1 else {}
parse*Drive*Spec?
If it does what you need and is more general then name should be updated to reflect what
it really does
Line 553: options['includePartitioned'] =
options.get('includePartitioned',
Please removing trailing space
--
To view, visit
http://gerrit.ovirt.org/4828
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I388442f361ea4ae00e3d8878a2497c7819ab2214
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>