Change in vdsm[master]: Orthogonal storage repository conversion

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Orthogonal storage repository conversion
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(4 inline comments)

....................................................
Commit Message
Line 7: Orthogonal storage repository conversion
sd upgrade is creepy as it is. Could you explain this new feature? What
"orthogonal" here?

....................................................
File vdsm/storage/imageRepository/Makefile.am
Line 2: # Copyright 2008-2011 Red Hat, Inc.
no, it's new in 2012

....................................................
File vdsm/storage/sdc.py
Line 54:         return self._impl
this would make jenkins cry.

....................................................
File vdsm/storage/sd.py
Line 354:         return str(self.getVersion())
I have an old vendeta against str(). Could you use unicode() here?

--
To view, visit http://gerrit.ovirt.org/3045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f43faaa9578ddafbae8e3aa01c02b1d42b177ab
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;