Saggi Mizrahi has posted comments on this change.
Change subject: BZ#732980 MD tag must be in blocks unit
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 103: BLOCK_SD_MD_FIELDS.update({
Line 104: # Key dec, enc
Line 105: DMDK_PV_REGEX : (decodePVInfo, encodePVInfo),
Line 106: DMDK_VGUUID : (str, str),
Line 107: DMDK_LOGBLKSIZE : (lambda x: sd.intOrDefault(DEFAULT_BLOCKSIZE, x), str),
Using funtools.partial is preferable
Line 108: DMDK_PHYBLKSIZE : (lambda x: sd.intOrDefault(DEFAULT_BLOCKSIZE, x), str),
Line 109: })
Line 110:
Line 111: INVALID_CHARS = re.compile(r"[^a-zA-Z0-9_+.\-/=!:#]")
--
To view, visit
http://gerrit.usersys.redhat.com/891
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id268735f60a289f9e8f12a7d7bb3180bf3398c54
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>