Yoav Kleinberger has posted comments on this change.
Change subject: tests: use 'localhost' explicitly in test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28107/1/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 79: isSSL = config.getboolean('vars', 'ssl')
Line 80: if isSSL and os.geteuid() != 0:
Line 81: raise SkipTest("Must be root to use SSL connection to
server")
Line 82: address = 'localhost:%s' % config.get('addresses',
'management_port')
Line 83: self.s = vdscli.connect(hostPort=address, useSSL=isSSL)
pushing heuristics down to vdscli might have been bad and misguided.
I can
we used the existing VDS client API, so I don't see how we will make
tests fail that did not fail previously.
The test explicitly *wants* to use the localhost, so now it is explicitly written in it.
This is how it should be, even if the heuristic you mentioned would have worked (it
doesn't on my host).
Line 84:
Line 85: def assertVdsOK(self, vdsResult):
Line 86: # code == 0 means OK
Line 87: self.assertEquals(
--
To view, visit
http://gerrit.ovirt.org/28107
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes