Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: Make Link.flags official as they are used for RUNNING and
PROMISC
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36621/1/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:
Line 118: _hiddenVlans = config.get('vars',
'hidden_vlans').split(',')
Line 119: IFF_RUNNING = 1 << 6
Line 120: IFF_PROMISC = 1 << 8
Line 121:
Line 122: def __init__(self, address, index, linkType, mtu, name, qdisc, state,
our code ALREADY assumes that "flags" is always passed here. So please make
"flags" mandatory.
Change the commit message accordingly - we want to fail hard on a missing flag.
Line 123: vlanid=None, vlanprotocol=None, master=None, device=None,
Line 124: flags=None, **kwargs):
Line 125: self.address = address
Line 126: self.index = index
--
To view, visit
http://gerrit.ovirt.org/36621
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc9e516e28d3413274af85dc15f72cabdb64074a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes