Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 332:         self.assertEquals(p.finished, True)
Line 333: 
Line 334: 
Line 335: @expandPermutations
Line 336: class TestCommit(TestCaseBase):
Add test for progress - testing chain with two empty images without writing any pattern,
and check that op.progress is 100.0 when operation is completed.
Line 337: 
Line 338:     @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 339:     def test_write_and_verify(self):
Line 340:         with namedTemporaryDir() as tmpdir:


Line 370:             qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 371:             qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)
Line 372: 
Line 373:     @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 374:     def test_commit_backing_chain(self):
Maybe test_commit_internal?
Line 375:         with namedTemporaryDir() as tmpdir:
Line 376:             base = os.path.join(tmpdir, 'base.img')
Line 377:             internal = os.path.join(tmpdir, 'internal.img')
Line 378:             top = os.path.join(tmpdir, 'top.img')


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes