From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: introduce pylint check
......................................................................
Patch Set 10:
(1 comment)
can you rebase on top of master, so we do not need to wait for the two pending pylint
patches?
https://gerrit.ovirt.org/#/c/69345/10/tox.ini
File tox.ini:
Line 34: PYTHONPATH = vdsm:lib
Line 35: deps =
Line 36: pylint==1.6.4
Line 37: commands =
Line 38: pylint --errors-only storage virt vdsm yajsonrpc vdsmclient
don't you need to explicitly list vdsm/*.py (since they are not in any python
package)?
I mean, are you sure you see errors from these files?
Line 39:
Line 40: [testenv:flake8]
Line 41: deps =
Line 42: flake8==3.0.4
--
To view, visit
https://gerrit.ovirt.org/69345
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85eca67784f82876b262b4452506e0f47486695b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes