Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/62094/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS2, Line 643: _proc
_procs (please note the trailing 's') is a bit clearer
Done
PS2, Line 648: nlike regular kill() we do not raise
: OSError if the processess have already terminated.
please add another sentence to explain why we do so.
Reprhased.
I am not sure if this is the best way to mimic the regular kill(). We could raise OSError
either when there is at least one process that has terminated, or (which might be better)
raise OSError when all processes have terminated.
However, we don't need any of this at the moment.
PS2, Line 660: @property
: def pid(self):
: return [p.pid for p in self._proc]
this is supposed to mimic `pid` as returned by process wrappers
returned by
Good point. Changed to pids.
--
To view, visit
https://gerrit.ovirt.org/62094
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c3741ae7ef9731a2cd9d587e86766b9e6e64f62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes